[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kio/bookmarks
From:       Frerich Raabe <raabe () kde ! org>
Date:       2005-02-09 7:59:18
Message-ID: 200502090859.23423.raabe () kde ! org
[Download RAW message or body]


On Monday 07 February 2005 12:50, you wrote:
> On Monday 31 January 2005 02:37, you wrote:
> > +bool KBookmark::hasMetaData() const
> >  {
> >      QDomNode n = cd_or_create( internalElement(), "info" );
> >      n = findOrCreateMetadata( n );
> > +    return !n.firstChild().isNull();
>
> Creating an info or a metadata element from a const method looks rather
> wrong to me.

How does it change the *observeable* state of the object?

> . (How does it even compile?) 

findOrCreateMetadata is not a member function.

- Frerich

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]