[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kio/bookmarks
From:       David Faure <faure () kde ! org>
Date:       2005-02-07 11:50:15
Message-ID: 200502071250.15864.faure () kde ! org
[Download RAW message or body]

On Monday 31 January 2005 02:37, you wrote:
> +bool KBookmark::hasMetaData() const
>  {
>      QDomNode n = cd_or_create( internalElement(), "info" );
>      n = findOrCreateMetadata( n );
> +    return !n.firstChild().isNull();

Creating an info or a metadata element from a const method looks rather wrong to me.
(How does it even compile?)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]