[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenonbeta/kio_mhtml
From:       Frerich Raabe <raabe () kde ! org>
Date:       2005-01-12 12:36:57
Message-ID: 200501121337.02395.raabe () kde ! org
[Download RAW message or body]


On Wednesday 12 January 2005 13:26, David Faure wrote:
> On Wednesday 12 January 2005 09:14, Frerich Raabe wrote:
> > On Monday 10 January 2005 17:29, Spiros Georgaras wrote:
> >
> > [I'm not quoting the relevant code excerpt here since that looks awful in
> > KMail.]
> >
> > All your checks like 'fullPath.right(4).lower()==".mht"' could nicely get
> > replaced with 'fullPath.endsWith( ".mht", false );' (the second parameter
> > meaning 'no case-sensitive comparison').
>
> Or using KMimeType instead of hardcoded extensions checks :)

Oh yes, even better! *smoooch*

Oh wait, this isn't kde-loveboat, is it? Forget what I did. :-)

- Frerich


[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]