[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenetwork/kopete/protocols/oscar/oscarsocket
From:       Matt Rogers <mattr () kde ! org>
Date:       2004-11-18 0:35:58
Message-ID: 200411171835.58289.mattr () kde ! org
[Download RAW message or body]

On Wednesday 17 November 2004 05:01 pm, Christoph Cullmann wrote:
> On Wednesday 17 November 2004 23:59, Matt Rogers wrote:
> > CVS commit by mattr:
> >
> > 17 characters because AIM passwords can be 16 characters long.
> >
> >
> >   M +2 -2      oscarsocket.aim.cpp   1.32
> >
> >
> > --- kdenetwork/kopete/protocols/oscar/oscarsocket/oscarsocket.aim.cpp
> > #1.31:1.32 @@ -46,7 +46,7 @@ void OscarSocket::sendLoginAIM(void)
> >          outbuf.addTLV(0x0001,getSN().length(),getSN().latin1());
> >
> > -        char digest[16];
> > +        char digest[17];
> >          encodePassword(&digest[0]);
> > -        digest[16] = '\0';  //do this so that addTLV sees a
> > NULL-terminator +        digest[17] = '\0';  //do this so that addTLV
> > sees a NULL-terminator
> >
> >          outbuf.addTLV(0x0025, 16, &digest[0]);
>
> same here as in the branch commit, off by one
> was wrong before for 16, now wrong for 17

right, a backport will follow before KDE 3.3.2

Matt
-- 
"I'll carry your books, I'll carry a tune, I'll carry on, carry over,
carry forward, Cary Grant, cash & carry, Carry Me Back To Old Virginia,
I'll even Harry Carey if you show me how, but I will *not* carry a gun."
                -- Hawkeye, M*A*S*H

[prev in list] [next in list] [prev in thread] [next in thread]