[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenetwork/kopete/protocols/oscar/oscarsocket
From:       Christoph Cullmann <cullmann () babylon2k ! de>
Date:       2004-11-17 23:01:14
Message-ID: 200411180001.21095 () cullmann
[Download RAW message or body]


On Wednesday 17 November 2004 23:59, Matt Rogers wrote:
> CVS commit by mattr:
>
> 17 characters because AIM passwords can be 16 characters long.
>
>
>   M +2 -2      oscarsocket.aim.cpp   1.32
>
>
> --- kdenetwork/kopete/protocols/oscar/oscarsocket/oscarsocket.aim.cpp 
> #1.31:1.32 @@ -46,7 +46,7 @@ void OscarSocket::sendLoginAIM(void)
>          outbuf.addTLV(0x0001,getSN().length(),getSN().latin1());
>
> -        char digest[16];
> +        char digest[17];
>          encodePassword(&digest[0]);
> -        digest[16] = '\0';  //do this so that addTLV sees a
> NULL-terminator +        digest[17] = '\0';  //do this so that addTLV sees
> a NULL-terminator
>
>          outbuf.addTLV(0x0025, 16, &digest[0]);
same here as in the branch commit, off by one
was wrong before for 16, now wrong for 17

-- 
Christoph Cullmann
KDE Developer, kde.org Maintainance Team
http://www.babylon2k.de, cullmann@kde.org

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]