[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeaddons/konq-plugins/webarchiver
From:       Andreas Schlapbach <schlpbch () iam ! unibe ! ch>
Date:       2004-10-02 7:55:13
Message-ID: Pine.GSO.4.58.0410020954190.8031 () asterix
[Download RAW message or body]

Hi Antonio

Fine with me!

Have a relaxing weekend,
Andreas

On Thu, 30 Sep 2004, Antonio Larrosa Jimenez wrote:

> CVS commit by antlarr:
>
> Frank Pieczynski made a patch to remove the message box that
> appears when the file saving is finished, Andreas Schlapbach
> and me, both agreed to remove that message box, but just before
> commiting I thought that removing it would cause another problem:
> there wouldn't be any way to "actively" tell the user that it has finished
> and users would have to poll the dialog each now and then, so I've
> replaced the message box with a passive popup, which doesn't get in the way
> as the old message box did, but at the same time, "actively" tells the user
> that it finished.
>
> I hope it's ok also to you, Andreas and Frank, if you see any problem
> with it, please tell me.
>
> CCMAIL: pieczy@web.de, schlpbch@iam.unibe.ch
>
>
>
>   M +2 -2      archivedialog.cpp   1.15
>
>
> --- kdeaddons/konq-plugins/webarchiver/archivedialog.cpp  #1.14:1.15
> @@ -29,4 +29,5 @@
>  #include <kfiledialog.h>
>  #include <kmessagebox.h>
> +#include <kpassivepopup.h>
>  #include <klocale.h>
>  #include <kio/netaccess.h>
> @@ -153,6 +154,5 @@ void ArchiveDialog::setSavingState()
>     m_tarBall->close();
>
> -   KMessageBox::information(0L, i18n( "Archiving webpage completed." ),
> -       QString::null, QString::null, false);
> +   KPassivePopup::message( m_url.prettyURL() , i18n( "Archiving webpage completed." ), this );
>
>     enableButtonOK(true);
>
>
>

--
I think, therefore IAM.

Andreas Schlapbach           PhD student
Artificial Intelligence Group
University of Berne
http://www.iam.unibe.ch/~schlpbch
[prev in list] [next in list] [prev in thread] [next in thread]