[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: proko2: kdepim/kresources/kolab/knotes
From:       David Faure <faure () kde ! org>
Date:       2004-07-05 11:57:51
Message-ID: 200407051357.52300.faure () kde ! org
[Download RAW message or body]

On Monday 05 July 2004 13:53, Michael Brade wrote:
> On Monday 05 July 2004 12:59, David Faure wrote:
> > On Thursday 01 July 2004 14:34, Michael Brade wrote:
> > > On Wednesday 30 June 2004 19:20, David Faure wrote:
> > > > (I wonder why it's not done in KNotesResourceManager::addNewNote
> > > > instead of doing it in all resources, but I didn't dare touching that).
> > >
> > > Because <resource>::load() needs to addNewNote(), but must not
> > > registerNote(), i.e. <resource>::addNote(). Otherwise you'd end up with
> > > infinite loops or double notes.
> >
> > I don't see any call to addNewNote() in either <resource>::load()...
> > On the contrary, they call registerNote() directly.
> Oops, I confused your suggestion with merging registerNote and addNewNote, and 
> even gave an explanation that doesn't fit either suggestions (what was my 
> mind up to??)
> 
> Anyway, it's fine, we should call registerNote in addNewNote and forget about 
> it in the resource::addNote. Should I do it or do you want to? :)

Please go ahead for the knotes code (I might miss a resource somewhere?), 
I'll fix the proko2 branch.
Thanks.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]