[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: proko2: kdepim/kresources/kolab/knotes
From:       Michael Brade <brade () kde ! org>
Date:       2004-07-05 11:53:15
Message-ID: 200407051355.17459.brade () kde ! org
[Download RAW message or body]


On Monday 05 July 2004 12:59, David Faure wrote:
> On Thursday 01 July 2004 14:34, Michael Brade wrote:
> > On Wednesday 30 June 2004 19:20, David Faure wrote:
> > > (I wonder why it's not done in KNotesResourceManager::addNewNote
> > > instead of doing it in all resources, but I didn't dare touching that).
> >
> > Because <resource>::load() needs to addNewNote(), but must not
> > registerNote(), i.e. <resource>::addNote(). Otherwise you'd end up with
> > infinite loops or double notes.
>
> I don't see any call to addNewNote() in either <resource>::load()...
> On the contrary, they call registerNote() directly.
Oops, I confused your suggestion with merging registerNote and addNewNote, and 
even gave an explanation that doesn't fit either suggestions (what was my 
mind up to??)

Anyway, it's fine, we should call registerNote in addNewNote and forget about 
it in the resource::addNote. Should I do it or do you want to? :)

-- 
Michael Brade;                 KDE Developer, Student of Computer Science
  |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2'
   °--web: http://www.kde.org/people/michaelb.html

KDE 3: The Next Generation in Desktop Experience

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]