[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/filters/karbon/svg
From:       Rob Buis <rwlbuis () xs4all ! nl>
Date:       2004-04-30 21:12:07
Message-ID: 20040430211207.GB47535 () xs4all ! nl
[Download RAW message or body]

Hi Adrian,

Thnx, well spot!
Cheers,

Rob.
On Fri, Apr 30, 2004 at 11:04:04PM +0200, Adrian Page wrote:
> CVS commit by page: 
> 
> Arguments can be evaluated in any order so pre/post inc/decrement leads to \
> undefined behaviour. 
> 
> M +6 -3      svgimport.cc   1.124
> 
> 
> --- koffice/filters/karbon/svg/svgimport.cc  #1.123:1.124
> @@ -742,13 +742,16 @@ SvgImport::parseGroup( VGroup *grp, cons
> points.remove( '\n' );
> QStringList pointList = QStringList::split( ' ', points );
> -                        for( QStringList::Iterator it = pointList.begin(); it != \
> pointList.end(); it++ ) +                        for( QStringList::Iterator it = \
> pointList.begin(); it != pointList.end(); ) {
> +                                KoPoint point;
> +                                point.setX( (*(it++)).toDouble() );
> +                                point.setY( (*(it++)).toDouble() );
> if( bFirst )
> {
> -                                        path->moveTo( KoPoint( \
> (*(it++)).toDouble(), (*it).toDouble() ) ); +                                       \
> path->moveTo( point ); bFirst = false;
> }
> else
> -                                        path->lineTo( KoPoint( \
> (*(it++)).toDouble(), (*it).toDouble() ) ); +                                       \
> path->lineTo( point ); }
> if( b.tagName() == "polygon" ) path->close();
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]