[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE_3_2_BRANCH: kdepim/kmail
From:       Ingo =?windows-1252?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2004-03-29 18:50:40
Message-ID: 200403292050.45367 () erwin ! ingo-kloecker ! de
[Download RAW message or body]


On Monday 29 March 2004 02:01, Maks Orlovich wrote:
> On Sunday 28 March 2004 07:35 am, Ingo Klöcker wrote:
> > On Sunday 28 March 2004 14:32, Sandro Giessl wrote:
> > > Am Sunday 28 March 2004 14:21 schrieb Sandro Giessl:
> > > > CVS commit by giessl:
> > > >
> > > > Backport framewidth changes (rev. 1.611) I committed a few
> > > > weeks ago to HEAD.
> > >
> > > Do you think this is worth an entry in the 3.2.2 changelog?
> >
> > I have no idea whether it has a great impact on the look of KMail
> > with other styles than Keramik because I'm using Keramik. If you
> > think that KMail now looks much better with other styles then feel
> > free to add an entry to the 3.2.2 changelog. Something like
> > "Improved look of KMail with other styles than Keramik.".
>
> Ugh. Can someone please explain what this change is about?

In KMail we used style().pixelMetric( QStyle::PM_DefaultFrameWidth ) - 1 
as frame width (that's the width of the frame around the different 
panes in KMail's main window). With Keramik style it looks better this 
way. But according to Sandro it looks better with other styles if the 
frame width is not decreased by one. Therefore he provided an 
appropriate patch. Now we use 
style().pixelMetric( QStyle::PM_DefaultFrameWidth ) - 1 for Keramik 
style and style().pixelMetric( QStyle::PM_DefaultFrameWidth ) for all 
other styles.

Regards,
Ingo

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]