[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE_3_1_BRANCH: kdenetwork/kmail
From:       Karl-Heinz Zimmer <khz () kde ! org>
Date:       2004-01-20 12:21:02
Message-ID: 200401201321.02656 () postmaster ! bugcops ! org
[Download RAW message or body]


On Dienstag, 20. Januar 2004 12:39, LukᨠTinkl wrote:
> Dne út 20. ledna 2004 11:49 Karl-Heinz Zimmer napsal(a):
> > On Dienstag, 20. Januar 2004 10:05, LukᨠTinkl wrote:
> > > Dne po 19. ledna 2004 23:11 Karl-Heinz Zimmer napsal(a):
> > > > CVS commit by khz:
> > > >
> > > > Important bugfix: We may not use the QCString representation of
> > > > encrypted data but we have to use the original QByteArray since
> > > > if may happen that in encrypted data there are  \0  characters
> > > > which would result in the QCString being truncated and thus
> > > > decrypting not possible.
> > >
> > > Are you sure it's the right branch you wanted to backport to?
> >
> > backport?
> >
> > I did not intend to backport, just wanted to fix this bug.
> >
> > The bug only appeared in KDE_3_1_BRANCH and actually I have
> > no idea how this bug could happen: I was rather sure all of
> > these "Avoid Zero characters" traps had been detected and the
> > respective  bugs fixed ages ago.  :-O
>
> Aha, so this bug doesn't exist in HEAD, right?

Yes, the code in HEAD (there it is in objecttreeparser.cpp - not in
 kmreaderwin.cpp) is doing it correctly: ciphertext.data() is a char* 
coming from the QByteArray - just as it should be.

Karl-Heinz
-- 
Karl-Heinz Zimmer, Senior Software Engineer, Klarälvdalens Datakonsult AB
<mailto:khz@klaralvdalens-datakonsult.se>            <mailto:khz@kde.org>

For every complex problem there is an answer that is clear, simple, and 
wrong.

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]