From kde-commits  Tue Jan 20 12:21:02 2004
From: Karl-Heinz Zimmer <khz () kde ! org>
Date: Tue, 20 Jan 2004 12:21:02 +0000
To: kde-commits
Subject: Re: KDE_3_1_BRANCH: kdenetwork/kmail
Message-Id: <200401201321.02656 () postmaster ! bugcops ! org>
X-MARC-Message: https://marc.info/?l=kde-commits&m=107460889803772
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-02=_u0RDA0966eEjGzO"


--Boundary-02=_u0RDA0966eEjGzO
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Description: signed data
Content-Disposition: inline

On Dienstag, 20. Januar 2004 12:39, Luk=E1=A8 Tinkl wrote:
> Dne =FAt 20. ledna 2004 11:49 Karl-Heinz Zimmer napsal(a):
> > On Dienstag, 20. Januar 2004 10:05, Luk=E1=A8 Tinkl wrote:
> > > Dne po 19. ledna 2004 23:11 Karl-Heinz Zimmer napsal(a):
> > > > CVS commit by khz:
> > > >
> > > > Important bugfix: We may not use the QCString representation of
> > > > encrypted data but we have to use the original QByteArray since
> > > > if may happen that in encrypted data there are  \0  characters
> > > > which would result in the QCString being truncated and thus
> > > > decrypting not possible.
> > >
> > > Are you sure it's the right branch you wanted to backport to?
> >
> > backport?
> >
> > I did not intend to backport, just wanted to fix this bug.
> >
> > The bug only appeared in KDE_3_1_BRANCH and actually I have
> > no idea how this bug could happen: I was rather sure all of
> > these "Avoid Zero characters" traps had been detected and the
> > respective  bugs fixed ages ago.  :-O
>
> Aha, so this bug doesn't exist in HEAD, right?

Yes, the code in HEAD (there it is in objecttreeparser.cpp - not in
 kmreaderwin.cpp) is doing it correctly: ciphertext.data() is a char*=20
coming from the QByteArray - just as it should be.

Karl-Heinz
=2D-=20
Karl-Heinz Zimmer, Senior Software Engineer, Klar=E4lvdalens Datakonsult AB
<mailto:khz@klaralvdalens-datakonsult.se>            <mailto:khz@kde.org>

=46or every complex problem there is an answer that is clear, simple, and=20
wrong.

--Boundary-02=_u0RDA0966eEjGzO
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQBADR0uCcaVnbvggDcRAo63AKCw6Uvlnd2yB5IfmJMBV21tF4LWYQCfefaP
4xlEfV5RlnwmMzI5U61d0+Y=
=PwXd
-----END PGP SIGNATURE-----

--Boundary-02=_u0RDA0966eEjGzO--