[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/kio
From:       David Faure <faure () kde ! org>
Date:       2003-11-24 12:01:36
[Download RAW message or body]

CVS commit by faure: 

Nice try, but QVariant(true) doesn't create a Boolean variant!


  M +16 -19    kio/kservice.cpp   1.152
  M +3 -0      tests/ktradertest.cpp   1.10


--- kdelibs/kio/kio/kservice.cpp  #1.151:1.152
@@ -511,5 +511,5 @@ QVariant KService::property( const QStri
   }
 
-  // Then we use a homebuild class based on KBaseConfig to convert the QString.
+  // Then we use a homebuild class based on KConfigBase to convert the QString.
   // For some often used property types we do the conversion ourselves.
   QMap<QString,QVariant>::ConstIterator it = m_mapProps.find( _name );
@@ -540,8 +540,5 @@ QVariant KService::property( const QStri
            if (t == QVariant::Bool)
            {
-              if (val)
-                 return QVariant(true);
-              else
-                 return QVariant(false);
+               return QVariant((bool)val, 1);
            }
            return QVariant(val);

--- kdelibs/kio/tests/ktradertest.cpp  #1.9:1.10
@@ -77,4 +77,7 @@ int main( int argc, char **argv )
           outp += prop.toStringList().join(" - ");
         break;
+        case QVariant::Bool:
+          outp += prop.toBool() ? "TRUE" : "FALSE";
+          break;
         default:
           outp += prop.toString();


[prev in list] [next in list] [prev in thread] [next in thread]