[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenetwork/kopete/kopete
From:       Olivier Goffart <ogoffart () tiscalinet ! be>
Date:       2003-09-09 10:46:26
[Download RAW message or body]


Le Mardi 9 Septembre 2003 12:34, vous avez écrit :
> On Tuesday 09 September 2003 11:47, Olivier Goffart wrote:
> > CVS commit by ogoffart:
> >
> > Fix the kopete command line options.
>
> Can you tell me WTF you're doing?!? You're moving the noplugins check way
> up the tree, this way you can still end up with plugins being loaded.

yes, if i call kopete --noplugins msn    
that mean i disable all plugins, but i still want to load MSN

> And  you also broke the check for when to show the config dialog along the
>  way.

I didn't broke it.  i still do all needed checks, and show it if: 1) no 
plugins are selected and 2) the user did not use some arg.

this is even beter than before because:
kopete --disable msn   
showed it if only msn was in the config
(i could remove one FIXME:  ;-} )

>
> All these options worked fine,

at least the --disable  did not work because  config->setGroup was not called.

>  please revert.

I will not revert.
I tested it, and i think it works beter than before.


[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]