[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenetwork/kopete/kopete
From:       Martijn Klingens <klingens () kde ! org>
Date:       2003-09-09 10:34:06
[Download RAW message or body]

On Tuesday 09 September 2003 11:47, Olivier Goffart wrote:
> CVS commit by ogoffart:
>
> Fix the kopete command line options.

Can you tell me WTF you're doing?!? You're moving the noplugins check way up 
the tree, this way you can still end up with plugins being loaded. And you 
also broke the check for when to show the config dialog along the way.

All these options worked fine, please revert.

> if ( !argument.startsWith( "kopete_" ) )
>    argument.prepend( "kopete_" );
>
> does this make sense? isn't there possible to have plugins which does not
> start with kopete_

Unlikely, because then they're installing DSOs with filenames that don't have 
the "kopete_" prefix, messing up the KDE installation dir. Technically, yes, 
it's possible, but in practice I think we can safely call it a bug if anyone 
attempts it.

-- 
Martijn
[prev in list] [next in list] [prev in thread] [next in thread]