[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeartwork/kscreensaver/kxsconfig
From:       George Staikos <staikos () kde ! org>
Date:       2003-05-28 13:12:23
[Download RAW message or body]

On Wednesday 28 May 2003 09:06, Cornelius Schumacher wrote:
> > > If you don't want to clean up your own mess, please don't do the
> > > changes.
> >
> >     It's not my mess to begin with.
>
> I don't know, if your own changes broke something, but at least kdepim was
> broken after these "check dynamic_cast for 0" changes.

   Ok but my changes are my changes, not others.  Please judge them as such.

> > I didn't change the cast because that
> > could be dangerous and requires testing.  I just put in comments or 0L
> > checks where safe/appropriate.  I was also responsible for 4 such casts,
> > and fixed my own code properly.
>
> What about submitting patches to the authors/maintainers instead of
> changing code you don't want to test or introducing unnecessary changes?
> This would have been a much more decent way to handle the problem.

    I changed far too many files.  I cannot manage tracking that many 
individual authors and patches, in which case I never would have gone to the 
effort of auditting.

   If anyone wants my log of what was auditted, what was clean, what was 
changed, etc, I have the file still.  There are lots of blanks in it still 
too.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

[prev in list] [next in list] [prev in thread] [next in thread]