[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeartwork/kscreensaver/kxsconfig
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2003-05-28 13:06:02
[Download RAW message or body]

On Wednesday 28 May 2003 14:57, George Staikos wrote:
> On Wednesday 28 May 2003 08:54, Cornelius Schumacher wrote:
> > On Wednesday 28 May 2003 14:39, George Staikos wrote:
> > > Hopefully the authors/maintainers can clean up properly after.
> >
> > If you don't want to clean up your own mess, please don't do the changes.
>
>     It's not my mess to begin with.

I don't know, if your own changes broke something, but at least kdepim was 
broken after these "check dynamic_cast for 0" changes.

> I didn't change the cast because that
> could be dangerous and requires testing.  I just put in comments or 0L
> checks where safe/appropriate.  I was also responsible for 4 such casts,
> and fixed my own code properly.

What about submitting patches to the authors/maintainers instead of changing 
code you don't want to test or introducing unnecessary changes? This would 
have been a much more decent way to handle the problem.

-- 
Cornelius Schumacher <schumacher@kde.org>

[prev in list] [next in list] [prev in thread] [next in thread]