[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeartwork/kscreensaver/kxsconfig
From:       George Staikos <staikos () kde ! org>
Date:       2003-05-28 12:39:57
[Download RAW message or body]

On Wednesday 28 May 2003 06:45, Dirk Mueller wrote:
> On Mit, 28 Mai 2003, George Staikos wrote:
> > check dynamic_cast for 0L
>
> is this a script?

  Almost.  find, grep >file and then manually check.  I got through a good 
chunk of CVS last night.

> > -        connect( dynamic_cast<QWidget*>(item), SIGNAL(changed()),
> > SLOT(slotChanged()) ); +        QWidget *i =
> > dynamic_cast<QWidget*>(item);
> > +        if (i) {
> > +            connect( i, SIGNAL(changed()), SLOT(slotChanged()) );
> > +        }
>
> hmm, thats not correct replacement. the dynamic_cast<> is completely
> unecessary here.
>
> it should have been replaced with item && item->isWidgetType()

   Yes in many places they probably weren't necessary, but I don't have time 
to fully test all of these changes so I'm trying to make non-intrusive 
changes.  Hopefully the authors/maintainers can clean up properly after.  I 
only changed my own code signficantly.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

[prev in list] [next in list] [prev in thread] [next in thread]