[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeartwork/kscreensaver/kxsconfig
From:       Dirk Mueller <mueller () kde ! org>
Date:       2003-05-28 10:45:27
[Download RAW message or body]

On Mit, 28 Mai 2003, George Staikos wrote:

> check dynamic_cast for 0L

is this a script?

> -        connect( dynamic_cast<QWidget*>(item), SIGNAL(changed()), SLOT(slotChanged()) );
> +        QWidget *i = dynamic_cast<QWidget*>(item);
> +        if (i) {
> +            connect( i, SIGNAL(changed()), SLOT(slotChanged()) );
> +        }

hmm, thats not correct replacement. the dynamic_cast<> is completely 
unecessary here. 

it should have been replaced with item && item->isWidgetType()


-- 
Dirk
[prev in list] [next in list] [prev in thread] [next in thread]