[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdemultimedia/noatun/modules/metatag
From:       Neil Stevens <neil () qualityassistant ! com>
Date:       2003-05-11 12:29:06
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday May 11, 2003 04:53, Daniel Molkentin wrote:
> On Sunday 11 May 2003 11:29, Neil Stevens wrote:
> >On Saturday May 10, 2003 01:42, Daniel Molkentin wrote:
> >> On Saturday 10 May 2003 22:29, Charles Samuels wrote:
> >> >Why is this necessary?
> >>
> >> It yields an amigous overload on the ctor (int, int, int..., vs.
> >> QWidget, int, int) on gcc 3.3pre.
> >
> >You can't expect to "fix" every app in existance to work with a
> > pre-release compiler this way.  Even if you "fix" every app in CVS,
> > everything outside will still fail.
>
> Sorry, this version comes with SuSE 8.2.

So?

> >Charles is right.  Fix it in a library.
>
> And am I supposed to fix that without breaking BC? Adding an empty
> parameter?

Hmm, I just looked, and I don't see a KDialogBase constructor that starts 
with int, int, int.  So which two are ambiguous?

KDialogBase( QWidget *parent=0, const char *name=0, bool modal=true,
KDialogBase( int dialogFace, const QString &caption, int buttonMask,
KDialogBase( int dialogFace, const QString &caption, QWidget *parent=0
KDialogBase( const QString &caption, int buttonMask, ButtonCode 
defaultButton

With the third one having been added recently (kdialogbase.h revision 
1.83).  Perhaps that new constructor should be removed?

- -- 
Neil Stevens - neil@qualityassistant.com
"The shepherd drives the wolf from the sheep's throat, for which the
sheep thanks the shepherd as a liberator, while the wolf denounces him
for the same act as the destroyer of liberty." -- Abraham Lincoln
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+vkISf7mnligQOmERAoZWAJ43lpjPi5/U+rjzgLD4UNUbk2DUJwCgmKN1
LOGqp4NjC3Fi3W3TTaoichA=
=btHV
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread]