[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdemultimedia/noatun/modules/metatag
From:       Luis Pedro Coelho <luis_pedro () netcabo ! pt>
Date:       2003-05-11 12:16:50
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Samedi 10 Mai 2003 22:46, Charles Samuels a écrit :
> That sounds like a Qt bug.  Perhaps the trolls should add keyword explicit
> somewhere?

Not Qt bug, KDE bug. And explicit is needed for _one argument_ constructors.

IMHO, the problem is that KDialogBase uses int instead of the enum type it 
actually expects. I think that disambiguating is really a good thing. I don't 
actually know what constructor would be called without the disambiguation. 
Note that the problem is only present if you are not defining 
QT_NO_CAST_ASCII since without that 0 -> QString is not possible. This is a 
Qt bug, yes. But that's why you have QT_NO_CAST_ASCII. Maybe not using 
QT_NO_CAST_ASCII should be considered a bug in its own right.

So, the disambiguation is needed. This is actually one of those cases which is 
possible to solve in BC fashion but by losing Source Compat, so it's probably 
out of the question before KDE 4.

HTH,
- -- 
Luis Pedro Coelho

"Technology does not always equal progress."
Douglas Coupland
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+vj9lGpBAvyRwXdgRArP1AJ42A0HJSNuy5YujLSItmqaAyCPGGgCgkUX7
IURHx7XWlqtRn2BYs7XjRvk=
=YbRd
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]