[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kdesktop
From:       "Dawit A." <adawit () kde ! org>
Date:       2003-03-13 1:29:20
[Download RAW message or body]

On Wednesday 12 March 2003 19:27, Dirk Mueller wrote:
> On Mit, 12 Mär 2003, Dawit A. wrote:
> > > And people who notice it's an assignment will think it's a typo and a
> > > == comparison was intended (or at least, wonder a while about it).
>
> Thats why you either write if ( foo == bar) or if ( ( foo = bar ) )
>
> Please note the extra brackets. Its not really uncommon coding style, and I
> do wonder why now suddenly people are surprised about it :)
>
> > That is exactly what I did and proceeded to break Minicli by making the
> > change. :(
>
> Well, coding style does not prevent that you have to test the patches
> before committing.

Well I thought I did. I simply had forgotten to restart kdesktop and hence 
assumed all was well after I compiled and installed the version I fixed, 
fwiw.

Dawit A.


[prev in list] [next in list] [prev in thread] [next in thread]