[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kdesktop
From:       Dirk Mueller <mueller () kde ! org>
Date:       2003-03-13 0:27:39
[Download RAW message or body]

On Mit, 12 Mär 2003, Dawit A. wrote:

> > And people who notice it's an assignment will think it's a typo and a ==
> > comparison was intended (or at least, wonder a while about it).

Thats why you either write if ( foo == bar) or if ( ( foo = bar ) ) 

Please note the extra brackets. Its not really uncommon coding style, and I 
do wonder why now suddenly people are surprised about it :)

> That is exactly what I did and proceeded to break Minicli by making the 
> change. :(

Well, coding style does not prevent that you have to test the patches before 
committing. 


-- 
Dirk

[prev in list] [next in list] [prev in thread] [next in thread]