[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/konqueror
From:       Eray Ozkural <erayo () cs ! bilkent ! edu ! tr>
Date:       2002-12-31 17:53:11
[Download RAW message or body]

CVS commit by exa: 

* fix slotOpenTerminal (closes #52375)
  - use KProcess in the simplest possible way to launch terminal program
    asynchronously, preventing GUI from blocking
  - less error prone and possibly faster


  M +6 -6      konq_mainwindow.cc   1.1101


--- kdebase/konqueror/konq_mainwindow.cc  #1.1100:1.1101
@@ -1125,10 +1125,10 @@ void KonqMainWindow::slotOpenTerminal()
   }
 
-  QString cmd = QString("cd ");
-  cmd += KProcess::quote(dir);
-  cmd += ";";
-  cmd += term;
-  kdDebug(1202) << "slotOpenTerminal: " << cmd << endl;
-  system( QFile::encodeName(cmd) );
+  KProcess cmd;
+  cmd.setWorkingDirectory(dir);
+  cmd << term;
+  kdDebug(1202) << "slotOpenTerminal: directory " << dir
+                << ", terminal:" << term << endl;
+  cmd.start(KProcess::DontCare);
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]