[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kstyles/highcolor
From:       Harri Porten <porten () kde ! org>
Date:       2002-12-30 12:20:05
[Download RAW message or body]

On Mon, 30 Dec 2002, Karol Szwed wrote:

> >CVS commit by mueller: 
> >
> >use static, avoiding symbol clashes
[...]
> I don't like this. We had crashes with static global objects in plugins 
> before. (e.g. in KWin plugins and with KStyle's static ShadowMap QDict, which 

The addition or lack of the "static" keyword doesn't make any difference
re the crash problem AFAIK. Commonly one speaks of "static global"
objects in both cases.

> Lars fixed by using a QSingleCleanupHandler<>)

Which is also a global object relying on proper construction and
destruction.

> An anonymous namespace would have been better imho.

Doesn't really hide the symbol unfortunately. Just results in aa
"anonymous" symbol name which is longer than usual and therefore bloating
things up.

Harri.

[prev in list] [next in list] [prev in thread] [next in thread]