[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kstyles/highcolor
From:       Karol Szwed <kszwed () kde ! org>
Date:       2002-12-30 7:48:38
[Download RAW message or body]

>CVS commit by mueller: 
>
>use static, avoiding symbol clashes
>
>
>  M +8 -9      highcolor.cpp   1.47

I don't like this. We had crashes with static global objects in plugins 
before. (e.g. in KWin plugins and with KStyle's static ShadowMap QDict, which 
Lars fixed by using a QSingleCleanupHandler<>)

An anonymous namespace would have been better imho.

[prev in list] [next in list] [prev in thread] [next in thread]