[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenetwork/kit
From:       Jason Katz-Brown <jason () katzbrown ! com>
Date:       2002-12-24 7:05:14
[Download RAW message or body]

CVS commit by katz: 

Mail to neil about this:

Heya!

I finished my KDE 3.1 install and noticed no Kit changes when I updated. So I 
installed Kit HEAD and noticed the new layout of the message window. I made 
two changes - move color buttons to their own vertical layout, and add a 
small border around the bottom section - don't you agree the lack of border 
around the buttons and edit was a little sore to the eye? In some ways 
however I see how you could say that it's against KDE standards, especially 
making the border marginHint() / 2. However, I argue that that main window is 
pretty much half dialog and half main window, so the margin should be in 
between :-)

Perhaps you should remove/correct the changes I made to Kit in HEAD 
(tmessage.cpp around line 211).

Is Kit going to be replaced in 3.2? 4.0? By light hawk? needing to run my own 
jabber server however doesn't sound like a very easy upgrade path though :-/

Thanks!!
Jason

PS. I actually got yelled at by the aol servers for signing on too often while 
testing the message window, so i couldn't test my final change, which was 
changing the lower box's margin to marginHint / 2. In my imagination though 
it looks pretty good.


  M +8 -2      tmessage.cpp   1.44


--- kdenetwork/kit/tmessage.cpp  #1.43:1.44
@@ -208,6 +208,12 @@ TMessage::TMessage(const QString &displa
 
         QHBox *bottomRow = new QHBox(centralWidget);
-        editFore = new KColorButton(bottomRow);
-        editBack = new KColorButton(bottomRow);
+        // make color buttons not directly against the edge
+        bottomRow->setMargin(KDialog::marginHint() / 2);
+        bottomRow->setSpacing(KDialog::spacingHint());
+        // make color buttons in their own vertical arrangement - jason
+        QVBox *colors = new QVBox(bottomRow); 
+        colors->setSpacing(KDialog::spacingHint());
+        editFore = new KColorButton(colors);
+        editBack = new KColorButton(colors);
         edit = new KTextEdit(bottomRow);
         connect(edit, SIGNAL(returnPressed()), this, SLOT(send()) );


[prev in list] [next in list] [prev in thread] [next in thread]