[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: /
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2002-12-11 11:17:04
[Download RAW message or body]

On Wed, Dec 11, 2002 at 12:23:48AM +0100, Dirk Mueller wrote:
> - more strlcpy configure check to admin/
>
good. but why didn't you add it to kde_misc_tests? now every module has
to use it explicitly, even though it is always linked. it has the same
status as snprintf, so it should be treated like this. the same applies
to all other functions in kdefakes, btw. if you're a pedant, you could
create a KDE_FAKES, which is invoked by KDE_MISC_TESTS instead of
inlining the checks there.

> - add assertion check that size_t == unsigned int
>
unsigned long is more correct.
anyway, i can say for sure, that this will break with some/all m$
compilers on 64-bit systems (sizeof(long) == 4, sizeof(size_t) ==
sizeof(long long) = 8). not that we would care for m$ ...
in any case, i think we needn't to refuse to build because of this -
after all, who cares, whether his strings can be 4gb or ... uhmm ...
quite a bit long?

greetings 

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]