[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror/iconview
From:       Michael Brade <brade () informatik ! uni-muenchen ! de>
Date:       2002-01-15 23:34:14
[Download RAW message or body]

On Tuesday 15 January 2002 23:41, Marc Mutz wrote:
> > > What's the use in removing
> > > #include <qregexp.h>
Uahh, I didn't notice that one yet :-((

> > > when the file explicitly uses it:
> > > konq_iconview.cc:376: QRegExp re( pattern, true, true );
> > Simple, gcc -E tells me that kdirlister.h already includes qregexp.h,
> > so konq_iconview doesn't need to include it.
>
> That's what I mean below: Suppose the #include in kdirlister wasn't
> necessary anymore and was replaced by a forward. Suddenly all the files
> massaged with fixincludes that include kdirlister.h break. Ugh.
Yeees!! And that's exactly why *I* added them, on quite a lot of places! :-( 
Seems nobody noticed it. kdirlister.h doesn't need a qregexp at all, that's 
why I removed it locally but didn't commit yet because the cache is working 
but not finished yet. Please, please revert the qregexp.h removal again.

Thanks,

-- 
Michael Brade;                 KDE Developer, Student of Computer Science
  |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2'
  °--web: http://www.kde.org/people/michaelb.html

KDE 3.0: Konquering the Desktops


[prev in list] [next in list] [prev in thread] [next in thread]