[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror/iconview
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-01-15 22:55:20
[Download RAW message or body]

On Tuesday 15 January 2002 23:24, Waldo Bastian wrote:
> On Tuesday 15 January 2002 12:20 pm, David Faure wrote:
> > > ? The preprocessor runs so fast compared to the compiler that you won't
> > > get any measureable speedup from this.
> >
> > That's not really true. Guess why we're using forward declarations in
> > header files, instead of including tons of header files from kde's header
> > files ? This isn't only about the preprocessor, it's about the number of
> > files that it needs to open. Harddisks are quite slow, relatively speaking
> > - I can hear mine spinning a lot while compiling, in any case ;)
> 
> Add more memory and all the header files will come out of cache >:-P Which 
> they will do anyway if kdirlister.h included the file already.

Guys, please understand that the main goal isn't about the duplicate inclusion 
like the qregexp.h coming from kdirlister.h, but about the really unneeded 
includes such as the ones I had in konq_run.cc after moving most of its code 
out. Yes, the script can't make the difference between the unneeded ones in 
there and the unneeded ones because included twice. Feel free to make a 
script intelligent enough for that.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david, http://www.konqueror.org
KDE 3.0: Konquering the Desktops

[prev in list] [next in list] [prev in thread] [next in thread]