[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 129765: Handle the case of an enum with visibility attributes.
From: Shaheed Haque <srhaque () theiet ! org>
Date: 2017-01-05 8:31:05
Message-ID: 20170105083105.13774.20060 () mimi ! kde ! org
[Download RAW message or body]
--===============2782995065808409873==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129765/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 8:31 a.m.)
Review request for Extra Cmake Modules.
Changes
-------
Added tests to verify that an enum with attributes can be read/evaluatred as \
expected.
Repository: extra-cmake-modules
Description
-------
The problem can be seen in the wild in, for example,
KActivitiesStats/kactivitiesstats/cleaning.h
Diffs (updated)
-----
find-modules/sip_generator.py 10be147711540437d38153fa8fe859bd34d7aa6c
tests/GenerateSipBindings/cpplib.h 0d63c30ed52b5d817c233e358b1ebce7a70c8218
tests/GenerateSipBindings/testscript.py 6f2132a2282208d914c0d5685fc78cf69e747b5e
Diff: https://git.reviewboard.kde.org/r/129765/diff/
Testing
-------
$ make test
Running tests...
Test project /home/.../extra-cmake-modules
Start 1: GenerateSipBindings
1/49 Test #1: GenerateSipBindings ................................... Passed \
8.59 sec Start 2: ExecuteCoreModules
2/49 Test #2: ExecuteCoreModules .................................... Passed \
0.46 sec Start 3: ExecuteKDEModules
Thanks,
Shaheed Haque
--===============2782995065808409873==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129765/">https://git.reviewboard.kde.org/r/129765/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Shaheed Haque.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2017, 8:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added tests to verify that an enum with attributes can \
be read/evaluatred as expected.</p></pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The problem can be seen in the wild in, for example, \
KActivitiesStats/kactivitiesstats/cleaning.h</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">$ make test Running tests...
Test project /home/.../extra-cmake-modules
Start 1: GenerateSipBindings
1/49 Test #1: GenerateSipBindings ................................... Passed \
8.59 sec Start 2: ExecuteCoreModules
2/49 Test #2: ExecuteCoreModules .................................... Passed \
0.46 sec Start 3: ExecuteKDEModules</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/sip_generator.py <span style="color: \
grey">(10be147711540437d38153fa8fe859bd34d7aa6c)</span></li>
<li>tests/GenerateSipBindings/cpplib.h <span style="color: \
grey">(0d63c30ed52b5d817c233e358b1ebce7a70c8218)</span></li>
<li>tests/GenerateSipBindings/testscript.py <span style="color: \
grey">(6f2132a2282208d914c0d5685fc78cf69e747b5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129765/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2782995065808409873==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic