[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 129765: Handle the case of an enum with visibility attributes.
From: Stephen Kelly <steveire () gmail ! com>
Date: 2017-01-04 23:32:13
Message-ID: 20170104233213.31377.37295 () mimi ! kde ! org
[Download RAW message or body]
--===============4346877733356187971==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 4, 2017, 10:11 p.m., Stephen Kelly wrote:
> > Hi Shaheed,
> >
> > Can you also add something to the unit test python code which asserts the (not \
> > zero) value of an enum with an attribute like this?
> > Thanks,
> >
> > Steve.
>
> Shaheed Haque wrote:
> You mean to validate it can be read as expected? Or something else?
Yes, exactly.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129765/#review101803
-----------------------------------------------------------
On Jan. 3, 2017, 11:18 p.m., Shaheed Haque wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129765/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 11:18 p.m.)
>
>
> Review request for Extra Cmake Modules.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> The problem can be seen in the wild in, for example,
> KActivitiesStats/kactivitiesstats/cleaning.h
>
>
> Diffs
> -----
>
> find-modules/sip_generator.py 10be147711540437d38153fa8fe859bd34d7aa6c
> tests/GenerateSipBindings/cpplib.h 0d63c30ed52b5d817c233e358b1ebce7a70c8218
>
> Diff: https://git.reviewboard.kde.org/r/129765/diff/
>
>
> Testing
> -------
>
> $ make test
> Running tests...
> Test project /home/.../extra-cmake-modules
> Start 1: GenerateSipBindings
> 1/49 Test #1: GenerateSipBindings ................................... Passed \
> 8.59 sec Start 2: ExecuteCoreModules
> 2/49 Test #2: ExecuteCoreModules .................................... Passed \
> 0.46 sec Start 3: ExecuteKDEModules
>
>
> Thanks,
>
> Shaheed Haque
>
>
--===============4346877733356187971==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129765/">https://git.reviewboard.kde.org/r/129765/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 4th, 2017, 10:11 p.m. UTC, <b>Stephen \
Kelly</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi Shaheed,</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you also add \
something to the unit test python code which asserts the (not zero) value of an enum \
with an attribute like this?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Thanks,</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Steve.</p></pre> </blockquote>
<p>On January 4th, 2017, 11:05 p.m. UTC, <b>Shaheed Haque</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
mean to validate it can be read as expected? Or something else?</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
exactly.</p></pre> <br />
<p>- Stephen</p>
<br />
<p>On January 3rd, 2017, 11:18 p.m. UTC, Shaheed Haque wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Shaheed Haque.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2017, 11:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The problem can be seen in the wild in, for example, \
KActivitiesStats/kactivitiesstats/cleaning.h</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">$ make test Running tests...
Test project /home/.../extra-cmake-modules
Start 1: GenerateSipBindings
1/49 Test #1: GenerateSipBindings ................................... Passed \
8.59 sec Start 2: ExecuteCoreModules
2/49 Test #2: ExecuteCoreModules .................................... Passed \
0.46 sec Start 3: ExecuteKDEModules</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/sip_generator.py <span style="color: \
grey">(10be147711540437d38153fa8fe859bd34d7aa6c)</span></li>
<li>tests/GenerateSipBindings/cpplib.h <span style="color: \
grey">(0d63c30ed52b5d817c233e358b1ebce7a70c8218)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129765/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4346877733356187971==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic