[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 119798: Generating PkgConfig files from ECM
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-09-01 13:51:01
Message-ID: 20140901135101.11809.48252 () probe ! kde ! org
[Download RAW message or body]
--===============2048103991071622165==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 29, 2014, 9:13 p.m., Alex Merry wrote:
> > modules/ECMGeneratePkgConfigFile.cmake, lines 144-147
> > <https://git.reviewboard.kde.org/r/119798/diff/4/?file=307659#file307659line144>
> >
> > Hmm... I wonder what happens if you have multiple calls in the same project with \
> > different LIB_INSTALL_DIR arguments. Edge case, perhaps, but it's not \
> > inconceivable something could compile a 32-bit and 64-bit version, say.
Well, in such edge case you can always specify ECM_PKGCONFIG_INSTALL_DIR or just \
decide not to pass the INSTALL argument and let the project do the installing.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/#review65528
-----------------------------------------------------------
On Aug. 26, 2014, 11:51 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119798/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 11:51 a.m.)
>
>
> Review request for Build System, KDE Frameworks and Harald Sitter.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> So we decided we wanted those .pc files, so I created a small script that generates \
> one, I haven't used pc in the past, so feedback is welcome.
>
> Diffs
> -----
>
> modules/ECMGeneratePkgConfigFile.cmake PRE-CREATION
> tests/CMakeLists.txt 65de038
> tests/ECMGeneratePkgConfigFile/CMakeLists.txt PRE-CREATION
> tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc PRE-CREATION
> tests/ECMGeneratePkgConfigFile/run_test.cmake.config PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119798/diff/
>
>
> Testing
> -------
>
> I added it in KCoreAddons, this is the patch:
> diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt
> index 26eb5a1..3a07d1c 100644
> --- src/lib/CMakeLists.txt
> +++ src/lib/CMakeLists.txt
> @@ -188,4 +188,6 @@ install(FILES
>
> include(ECMGeneratePriFile)
> ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS "core" \
> FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR \
> ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons) +ecm_generate_pkgconfig_file(BASE_NAME \
> KCoreAddons LIB_NAME KF5CoreAddons DEPS Qt5Core INCLUDE_INSTALL_DIR \
> ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons INSTALL) install(FILES ${PRI_FILENAME} \
> DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
> This is the result, on my system:
>
> Name: KF5CoreAddons
> Version: 5.1.0
> Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
> Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
> Requires: Qt5Core
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
--===============2048103991071622165==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119798/">https://git.reviewboard.kde.org/r/119798/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 29th, 2014, 9:13 p.m. UTC, <b>Alex \
Merry</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119798/diff/4/?file=307659#file307659line144" \
style="color: black; font-weight: bold; text-decoration: \
underline;">modules/ECMGeneratePkgConfigFile.cmake</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">144</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">if</span><span class="p">(</span><span class="s">EGPF_INSTALL</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">145</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">set</span><span class="p">(</span><span \
class="s">ECM_PKGCONFIG_INSTALL_DIR</span> <span \
class="s2">"${EGPF_LIB_INSTALL_DIR}/pkgconfig"</span> <span \
class="s">CACHE</span> <span class="s">PATH</span> <span class="s2">"The \
directory where pkgconfig will be installed to."</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">146</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">install</span><span class="p">(</span><span class="s">FILES</span> <span \
class="o">${</span><span class="nv">PKGCONFIG_FILENAME</span><span class="o">}</span> \
<span class="s">DESTINATION</span> <span class="o">${</span><span \
class="nv">ECM_PKGCONFIG_INSTALL_DIR</span><span class="o">}</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">147</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">endif</span><span class="p">()</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Hmm... I wonder what happens if you have multiple calls in the same project \
with different LIB_INSTALL_DIR arguments. Edge case, perhaps, but it's not \
inconceivable something could compile a 32-bit and 64-bit version, say.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Well, in such edge case you can always specify ECM_PKGCONFIG_INSTALL_DIR or \
just decide not to pass the INSTALL argument and let the project do the \
installing.</p></pre> <br />
<p>- Aleix</p>
<br />
<p>On August 26th, 2014, 11:51 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, KDE Frameworks and Harald Sitter.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2014, 11:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So we decided we wanted those .pc files, so I created \
a small script that generates one, I haven't used pc in the past, so feedback is \
welcome.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I added it in KCoreAddons, this is the patch:<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
index 26eb5a1..3a07d1c 100644<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
--- src/lib/CMakeLists.txt<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
+++ src/lib/CMakeLists.txt<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> @@ -188,4 +188,6 @@ install(FILES</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">include(ECMGeneratePriFile)<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS "core" \
FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR \
${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons)<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
+ecm_generate_pkgconfig_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS \
Qt5Core INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons INSTALL)<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> install(FILES ${PRI_FILENAME} DESTINATION \
${ECM_MKSPECS_INSTALL_DIR})</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This is the result, on my system:</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Name: KF5CoreAddons<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
Version: 5.1.0<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons <br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
Requires: Qt5Core</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMGeneratePkgConfigFile.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(65de038)</span></li>
<li>tests/ECMGeneratePkgConfigFile/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/ECMGeneratePkgConfigFile/run_test.cmake.config <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119798/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2048103991071622165==--
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic