--===============1262582824016595215== Content-Type: multipart/alternative; boundary="===============2048103991071622165==" --===============2048103991071622165== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 29, 2014, 9:13 p.m., Alex Merry wrote: > > modules/ECMGeneratePkgConfigFile.cmake, lines 144-147 > > > > > > Hmm... I wonder what happens if you have multiple calls in the same project with different LIB_INSTALL_DIR arguments. Edge case, perhaps, but it's not inconceivable something could compile a 32-bit and 64-bit version, say. Well, in such edge case you can always specify ECM_PKGCONFIG_INSTALL_DIR or just decide not to pass the INSTALL argument and let the project do the installing. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review65528 ----------------------------------------------------------- On Aug. 26, 2014, 11:51 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119798/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 11:51 a.m.) > > > Review request for Build System, KDE Frameworks and Harald Sitter. > > > Repository: extra-cmake-modules > > > Description > ------- > > So we decided we wanted those .pc files, so I created a small script that generates one, I haven't used pc in the past, so feedback is welcome. > > > Diffs > ----- > > modules/ECMGeneratePkgConfigFile.cmake PRE-CREATION > tests/CMakeLists.txt 65de038 > tests/ECMGeneratePkgConfigFile/CMakeLists.txt PRE-CREATION > tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc PRE-CREATION > tests/ECMGeneratePkgConfigFile/run_test.cmake.config PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119798/diff/ > > > Testing > ------- > > I added it in KCoreAddons, this is the patch: > diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt > index 26eb5a1..3a07d1c 100644 > --- src/lib/CMakeLists.txt > +++ src/lib/CMakeLists.txt > @@ -188,4 +188,6 @@ install(FILES > > include(ECMGeneratePriFile) > ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS "core" FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons) > +ecm_generate_pkgconfig_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS Qt5Core INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons INSTALL) > install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR}) > > This is the result, on my system: > > Name: KF5CoreAddons > Version: 5.1.0 > Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64 > Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons > Requires: Qt5Core > > > Thanks, > > Aleix Pol Gonzalez > > --===============2048103991071622165== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/

On August 29th, 2014, 9:13 p.m. UTC, Alex Merry wrote:

modules/ECMGeneratePkgConfigFile.cmake (Diff revision 4)
		144	if(EGPF_INSTALL)
		145	set(ECM_PKGCONFIG_INSTALL_DIR "${EGPF_LIB_INSTALL_DIR}/pkgconfig" CACHE PATH "The directory where pkgconfig will be installed to.")
		146	install(FILES ${PKGCONFIG_FILENAME} DESTINATION ${ECM_PKGCONFIG_INSTALL_DIR})
		147	endif()

Hmm... I wonder what happens if you have multiple calls in the same project with different LIB_INSTALL_DIR arguments. Edge case, perhaps, but it's not inconceivable something could compile a 32-bit and 64-bit version, say.

Well, in such edge case you can always specify ECM_PKGCONFIG_INSTALL_DIR or just decide not to pass the INSTALL argument and let the project do the installing.

- Aleix

On August 26th, 2014, 11:51 a.m. UTC, Aleix Pol Gonzalez wrote:

Review request for Build System, KDE Frameworks and Harald Sitter.

By Aleix Pol Gonzalez.

Updated Aug. 26, 2014, 11:51 a.m.

Repository: extra-cmake-modules

Description

So we decided we wanted those .pc files, so I created a small script that generates one, I haven't used pc in the past, so feedback is welcome.

Testing

I added it in KCoreAddons, this is the patch:

diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt

index 26eb5a1..3a07d1c 100644

--- src/lib/CMakeLists.txt

+++ src/lib/CMakeLists.txt

@@ -188,4 +188,6 @@ install(FILES
include(ECMGeneratePriFile)

 ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS "core" FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons)

+ecm_generate_pkgconfig_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS Qt5Core INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons INSTALL)

 install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
This is the result, on my system:
Name: KF5CoreAddons

Version: 5.1.0

Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64

Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons 

Requires: Qt5Core

Diffs

modules/ECMGeneratePkgConfigFile.cmake (PRE-CREATION)
tests/CMakeLists.txt (65de038)
tests/ECMGeneratePkgConfigFile/CMakeLists.txt (PRE-CREATION)
tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc (PRE-CREATION)
tests/ECMGeneratePkgConfigFile/run_test.cmake.config (PRE-CREATION)

--===============2048103991071622165==-- --===============1262582824016595215== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem --===============1262582824016595215==--