[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 119696: KDECompilerSettings: Be more portable across libc's.
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2014-08-12 22:00:13
Message-ID: 20140812220013.14668.74904 () probe ! kde ! org
[Download RAW message or body]
--===============4279346087717472129==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119696/#review64410
-----------------------------------------------------------
Ship it!
This seems reasonable, and proper compile checks for the system libc is the right \
approach.
- Alex Merry
On Aug. 10, 2014, 7:06 p.m., Raphael Kubo da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119696/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2014, 7:06 p.m.)
>
>
> Review request for Extra Cmake Modules and Alex Merry.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Defining _XOPEN_SOURCE to 500 is too restrictive: it corresponds to
> _POSIX_C_SOURCE 199506L, and hides several symbols that standard
> libraries like libc++ expect to find, leading to errors like this on
> FreeBSD:
>
> In file included from /tmp/attica/src/accountbalance.cpp:21:
> In file included from /tmp/attica/src/accountbalance.h:25:
> In file included from /usr/local/include/qt5/QtCore/QString:1:
> In file included from /usr/local/include/qt5/QtCore/qstring.h:50:
> In file included from /usr/include/c++/v1/string:437:
> In file included from /usr/include/c++/v1/string:437:
> /usr/include/c++/v1/cstdio:143:9: error: no member named 'snprintf' in the global \
> namespace using ::snprintf;
> ~~^
>
> This isn't a problem on Linux (actually, on systems using glibc) because
> defining _GNU_SOURCE enables a lot more features that are not made
> available on other libc implementations where it does not have any
> effect.
>
> Instead, stop defining _XOPEN_SOURCE at all and leave it up to the
> platform to show or hide as many symbols as necessary if no
> standards-related defines are set, and only set _GNU_SOURCE on systems
> where it is actually meaningful (ie. systems using glibc).
>
>
> Diffs
> -----
>
> kde-modules/KDECompilerSettings.cmake fdc930e48e489696e137c546fd7e00e0c4797243
>
> Diff: https://git.reviewboard.kde.org/r/119696/diff/
>
>
> Testing
> -------
>
> Attica builds on FreeBSD.
>
>
> Thanks,
>
> Raphael Kubo da Costa
>
>
--===============4279346087717472129==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119696/">https://git.reviewboard.kde.org/r/119696/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
seems reasonable, and proper compile checks for the system libc is the right \
approach.</p></pre> <br />
<p>- Alex Merry</p>
<br />
<p>On August 10th, 2014, 7:06 p.m. UTC, Raphael Kubo da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules and Alex Merry.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2014, 7:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Defining _XOPEN_SOURCE to 500 is too restrictive: it \
corresponds to<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> _POSIX_C_SOURCE 199506L, and hides several symbols \
that standard<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> libraries like libc++ expect to find, leading to \
errors like this on<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> FreeBSD:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In file included from \
/tmp/attica/src/accountbalance.cpp:21:<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> In file included \
from /tmp/attica/src/accountbalance.h:25:<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> In file included \
from /usr/local/include/qt5/QtCore/QString:1:<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> In file included \
from /usr/local/include/qt5/QtCore/qstring.h:50:<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> In file included \
from /usr/include/c++/v1/string:437:<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> In file included \
from /usr/include/c++/v1/string:437:<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
/usr/include/c++/v1/cstdio:143:9: error: no member named 'snprintf' in the global \
namespace<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> using ::snprintf;<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
~~^</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This isn't a problem on Linux (actually, on systems \
using glibc) because<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> defining _GNU_SOURCE enables a lot \
more features that are not made<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> available on other libc \
implementations where it does not have any<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> effect.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Instead, stop defining _XOPEN_SOURCE at all and leave \
it up to the<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> platform to show or hide as many symbols as \
necessary if no<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> standards-related defines are set, and only set \
_GNU_SOURCE on systems<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> where it is actually meaningful (ie. \
systems using glibc).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Attica builds on FreeBSD.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDECompilerSettings.cmake <span style="color: \
grey">(fdc930e48e489696e137c546fd7e00e0c4797243)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119696/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4279346087717472129==--
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic