'Review Request: Update FindPythonLibrary.cmake and PythonMacros.cmake.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Review Request: Update FindPythonLibrary.cmake and PythonMacros.cmake.
From:       "Luca Beltrame" <einar () heavensinferno ! net>
Date:       2012-10-31 6:44:57
Message-ID: 20121031064457.3060.6584 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107148/
-----------------------------------------------------------

Review request for Build System.

Description
-------

These adjustments ensure that the macros work with newer Python versions (w=
hich changed their behavior with byte-compiled files) and allow proper inst=
allation in systems where the name of the Python library is changed (see op=
enSUSE). Additionally, all the finding logic is now delegated to the proper=
 Find* packages in CMake. The variables are set to ensure source compatibil=
ity: those not set are directly taken from FindPythonInterp and FindPythonL=
ibs.

Additionally, PythonMacros is adjusted to ensure that Python files are prop=
erly byte-compiled and messages routed to the right place.

This change will be committed only to the 4.10 branch, as it relies on some=
 CMake functionality (VERSION_LESS, VERSION_GREATER, Python_ADDITIONAL_VERS=
IONS) only available in 2.8+.

Diffs
-----

  cmake/modules/FindPythonLibrary.cmake 60567e297f686ecc1a1c1f4bcebfd94181b=
fe116 =

  cmake/modules/PythonMacros.cmake 661e32d0c8fbc5a083fd7e8271557ae51c5e12d1 =

Diff: http://git.reviewboard.kde.org/r/107148/diff/

Testing
-------

Ran CMake in the PyKDE4 checkout, testing different interpreters and site-p=
ackages directories, no issues.

Thanks,

Luca Beltrame

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107148/">http://git.reviewboard.kde.org/r/107148/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Build System.</div>
<div>By Luca Beltrame.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">These adjustments ensure that the macros work with newer Python versions \
(which changed their behavior with byte-compiled files) and allow proper installation \
in systems where the name of the Python library is changed (see openSUSE). \
Additionally, all the finding logic is now delegated to the proper Find* packages in \
CMake. The variables are set to ensure source compatibility: those not set are \
directly taken from FindPythonInterp and FindPythonLibs.

Additionally, PythonMacros is adjusted to ensure that Python files are properly \
byte-compiled and messages routed to the right place.

This change will be committed only to the 4.10 branch, as it relies on some CMake \
functionality (VERSION_LESS, VERSION_GREATER, Python_ADDITIONAL_VERSIONS) only \
available in 2.8+.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran CMake in the PyKDE4 checkout, testing different interpreters and \
site-packages directories, no issues.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/modules/FindPythonLibrary.cmake <span style="color: \
grey">(60567e297f686ecc1a1c1f4bcebfd94181bfe116)</span></li>

 <li>cmake/modules/PythonMacros.cmake <span style="color: \
grey">(661e32d0c8fbc5a083fd7e8271557ae51c5e12d1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107148/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 