--===============3852186773131956649== Content-Type: multipart/alternative; boundary="===============7242182538537974211==" --===============7242182538537974211== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107148/ ----------------------------------------------------------- Review request for Build System. Description ------- These adjustments ensure that the macros work with newer Python versions (w= hich changed their behavior with byte-compiled files) and allow proper inst= allation in systems where the name of the Python library is changed (see op= enSUSE). Additionally, all the finding logic is now delegated to the proper= Find* packages in CMake. The variables are set to ensure source compatibil= ity: those not set are directly taken from FindPythonInterp and FindPythonL= ibs. Additionally, PythonMacros is adjusted to ensure that Python files are prop= erly byte-compiled and messages routed to the right place. This change will be committed only to the 4.10 branch, as it relies on some= CMake functionality (VERSION_LESS, VERSION_GREATER, Python_ADDITIONAL_VERS= IONS) only available in 2.8+. Diffs ----- cmake/modules/FindPythonLibrary.cmake 60567e297f686ecc1a1c1f4bcebfd94181b= fe116 = cmake/modules/PythonMacros.cmake 661e32d0c8fbc5a083fd7e8271557ae51c5e12d1 = Diff: http://git.reviewboard.kde.org/r/107148/diff/ Testing ------- Ran CMake in the PyKDE4 checkout, testing different interpreters and site-p= ackages directories, no issues. Thanks, Luca Beltrame --===============7242182538537974211== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107148/

Review request for Build System.
By Luca Beltrame.

Descripti= on 

These adjustments ensure that the macros work with newer Pyt=
hon versions (which changed their behavior with byte-compiled files) and al=
low proper installation in systems where the name of the Python library is =
changed (see openSUSE). Additionally, all the finding logic is now delegate=
d to the proper Find* packages in CMake. The variables are set to ensure so=
urce compatibility: those not set are directly taken from FindPythonInterp =
and FindPythonLibs.

Additionally, PythonMacros is adjusted to ensure that Python files are prop=
erly byte-compiled and messages routed to the right place.

This change will be committed only to the 4.10 branch, as it relies on some=
 CMake functionality (VERSION_LESS, VERSION_GREATER, Python_ADDITIONAL_VERS=
IONS) only available in 2.8+.

Testing <= /h1> 
Ran CMake in the PyKDE4 checkout, testing different interpre=
ters and site-packages directories, no issues.

Diffs=

  • cmake/modules/FindPythonLibrary.cmake (605= 67e297f686ecc1a1c1f4bcebfd94181bfe116)
  • cmake/modules/PythonMacros.cmake (661e32d0= c8fbc5a083fd7e8271557ae51c5e12d1)

View Diff
--===============7242182538537974211==-- --===============3852186773131956649== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem --===============3852186773131956649==--