[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: on finding KDE4
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2009-06-28 11:16:10
Message-ID: 757d9a550906280416w6a2489d0kd4cf6c2e3b2e0a8f () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


That's weird :P

Well, do you want me to commit a fix or you're fixing it?

Take care!
Aleix

On Sun, Jun 28, 2009 at 10:25 AM, Alexander Neundorf <neundorf@kde.org>wrote:

> On Sunday 28 June 2009, Aleix Pol wrote:
> > hi,
> > while looking through the code looking for a bug i ran into this code:
> >
> > get_target_property(_importedConfigurations
> > ${KDE4_TARGET_PREFIX}kconfig_compiler IMPORTED_CONFIGURATIONS )
> > list(GET _importedConfigurations 0 _firstConfig)
> >
> > get_target_property(KDE4_KCFGC_EXECUTABLE
> > ${KDE4_TARGET_PREFIX}kconfig_compiler LOCATION_${firstConfig})
> > get_target_property(KDE4_MEINPROC_EXECUTABLE
> > ${KDE4_TARGET_PREFIX}meinproc4        LOCATION_${firstConfig})
> > get_target_property(KDE4_MAKEKDEWIDGETS_EXECUTABLE
> > ${KDE4_TARGET_PREFIX}makekdewidgets   LOCATION_${firstConfig})
> >
> > Why isn't the property name like that (note the underscore)?
> > LOCATION_${_firstConfig}
>
> You are correct, this was wrong, I committed the fix to trunk and the 4.3
> branch.
>
> It still worked, because this was cmake was looking for the location of an
> not
> existing configuration, and if it does that, it returns the location for an
> arbitrary configuration.
>
> Alex
> _______________________________________________
> Kde-buildsystem mailing list
> Kde-buildsystem@kde.org
> https://mail.kde.org/mailman/listinfo/kde-buildsystem
>

[Attachment #5 (text/html)]

That&#39;s weird :P<br><br>Well, do you want me to commit a fix or you&#39;re fixing \
it?<br><br>Take care!<br>Aleix<br><br><div class="gmail_quote">On Sun, Jun 28, 2009 \
at 10:25 AM, Alexander Neundorf <span dir="ltr">&lt;<a \
href="mailto:neundorf@kde.org">neundorf@kde.org</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"><div><div></div><div class="h5">On Sunday 28 June \
2009, Aleix Pol wrote:<br> &gt; hi,<br>
&gt; while looking through the code looking for a bug i ran into this code:<br>
&gt;<br>
&gt; get_target_property(_importedConfigurations<br>
&gt; ${KDE4_TARGET_PREFIX}kconfig_compiler IMPORTED_CONFIGURATIONS )<br>
&gt; list(GET _importedConfigurations 0 _firstConfig)<br>
&gt;<br>
&gt; get_target_property(KDE4_KCFGC_EXECUTABLE<br>
&gt; ${KDE4_TARGET_PREFIX}kconfig_compiler LOCATION_${firstConfig})<br>
&gt; get_target_property(KDE4_MEINPROC_EXECUTABLE<br>
&gt; ${KDE4_TARGET_PREFIX}meinproc4            LOCATION_${firstConfig})<br>
&gt; get_target_property(KDE4_MAKEKDEWIDGETS_EXECUTABLE<br>
&gt; ${KDE4_TARGET_PREFIX}makekdewidgets    LOCATION_${firstConfig})<br>
&gt;<br>
&gt; Why isn&#39;t the property name like that (note the underscore)?<br>
&gt; LOCATION_${_firstConfig}<br>
<br>
</div></div>You are correct, this was wrong, I committed the fix to trunk and the \
4.3<br> branch.<br>
<br>
It still worked, because this was cmake was looking for the location of an not<br>
existing configuration, and if it does that, it returns the location for an<br>
arbitrary configuration.<br>
<br>
Alex<br>
_______________________________________________<br>
Kde-buildsystem mailing list<br>
<a href="mailto:Kde-buildsystem@kde.org">Kde-buildsystem@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-buildsystem" \
target="_blank">https://mail.kde.org/mailman/listinfo/kde-buildsystem</a><br> \
</blockquote></div><br>



_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


[prev in list] [next in list] [prev in thread] [next in thread]