[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bindings
Subject:    Re: PyKF5 use of the SIP second declaration
From:       Shaheed Haque <srhaque () theiet ! org>
Date:       2017-01-28 20:14:34
Message-ID: CAHAc2jdxPfJv3-ss6Dhn5tkjURkvGZgWM8PfOio8MFP+eru+cw () mail ! gmail ! com
[Download RAW message or body]

Just to close this thread...in the review I just posted, I renamed the
stuff like this:

decl2 -> cxx_decl
fn_result2 -> cxx_fn_result


On 21 January 2017 at 12:34, Shaheed Haque <srhaque@theiet.org> wrote:

> Thanks for confirming.
>
> As for the second declaration etc, the SIP specification at
> http://pyqt.sourceforge.net/Docs/sip4/specification_files.html refers to
> it as the "*c++-signature*", so I'll look into replacing the number with
> a suffix like "_cpp".
>
> Thanks, Shaheed
>
> On 21 January 2017 at 10:58, Stephen Kelly <steveire@gmail.com> wrote:
>
>> Shaheed Haque wrote:
>>
>> > Hi Steve,
>> >
>> > Another smallpoint to resolve is around the logic for the support of the
>> > second declaration in SIP files, e.g. the bit in [] brackets here:
>>
>> > I suggest that for consistency the second set of parameters should also
>> be
>> > an array:
>>
>> That makes sense to me.
>>
>> I'm not a fan of numbers in interfaces though. Can you choose alternate
>> names which convey what the second set of values are for?
>>
>> Thanks,
>>
>> Steve.
>>
>>
>

[Attachment #3 (text/html)]

<div dir="ltr"><div><div><div>Just to close this thread...in the review I just \
posted, I renamed the stuff like this:<br></div><br></div>decl2 -&gt; \
cxx_decl<br></div>fn_result2 -&gt; \
cxx_fn_result<br><div><div><br></div></div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On 21 January 2017 at 12:34, Shaheed Haque <span dir="ltr">&lt;<a \
href="mailto:srhaque@theiet.org" target="_blank">srhaque@theiet.org</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Thanks for \
confirming.<br><br></div>As for the second declaration etc, the SIP specification at \
<a href="http://pyqt.sourceforge.net/Docs/sip4/specification_files.html" \
target="_blank">http://pyqt.sourceforge.net/<wbr>Docs/sip4/specification_files.<wbr>html</a> \
refers to it as the &quot;<em>c++-signature</em>&quot;, so I&#39;ll look into \
replacing the number with a suffix like &quot;_cpp&quot;.<br><br></div>Thanks, \
Shaheed<br></div><div class="HOEnZb"><div class="h5"><div \
class="gmail_extra"><br><div class="gmail_quote">On 21 January 2017 at 10:58, Stephen \
Kelly <span dir="ltr">&lt;<a href="mailto:steveire@gmail.com" \
target="_blank">steveire@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span>Shaheed Haque wrote:<br> <br>
&gt; Hi Steve,<br>
&gt;<br>
&gt; Another smallpoint to resolve is around the logic for the support of the<br>
&gt; second declaration in SIP files, e.g. the bit in [] brackets here:<br>
<br>
</span><span>&gt; I suggest that for consistency the second set of parameters should \
also be<br> &gt; an array:<br>
<br>
</span>That makes sense to me.<br>
<br>
I&#39;m not a fan of numbers in interfaces though. Can you choose alternate<br>
names which convey what the second set of values are for?<br>
<br>
Thanks,<br>
<br>
Steve.<br>
<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]