[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-bindings
Subject: Re: End of 2016 update on PyKF5 bindings
From: Shaheed Haque <srhaque () theiet ! org>
Date: 2017-01-21 15:33:30
Message-ID: CAHAc2jda9AeAkwbY87Gq1drvW8TKSsETZK81mtFennZixuh4Ag () mail ! gmail ! com
[Download RAW message or body]
Hi Steve,
I've tested that this change does not appear to break things. Full details,
including the testing, in https://git.reviewboard.kde.org/r/129763/. Kindly
review.
Thanks, Shaheed
On 19 January 2017 at 11:25, Shaheed Haque <srhaque@theiet.org> wrote:
> Hi Steve,
>
> On 18 January 2017 at 23:38, Stephen Kelly <steveire@gmail.com> wrote:
> > Shaheed Haque wrote:
> >
> >> Hi,
> >>
> >> On 18 January 2017 at 21:44, Stephen Kelly <steveire@gmail.com> wrote:
> >>> Shaheed Haque wrote:
> >>>
> >>>> HI Steve,
> >>>>
> >>>> I closed two of the reviews based on testing KDE/master. That leaves
> >>>> only https://git.reviewboard.kde.org/r/129763/: this should be
> >>>> non-controversial as it removes a functional no-op which just gets ion
> >>>> the way of my stuff, so please take a look at it when you can.
> >>>
> >>> This doesn't look like a no-op to me. I'm also generally not in favor
> of
> >>> adding things to ECM which do not directly help the goal of getting
> >>> bindings into frameworks repos.
> >>
> >> If you look at how the CMake constructs ${hdr_filename} and
> >> ${hdr_file}, you'll see that they are redundant.
> >
> > Hi Shaheed,
> >
> > It is not uncommon in kde repos (eg kcoreaddons) to specify files in
> > subdirectories, yet expect that the filename without subdirectory is
> what is
> > used in the #include. I think that's what you're seeing as 'redundancy'.
> > I've extended the ECM test for this case. I don't know if your patch
> affects
> > it.
>
> I see (I handle that differently!) so I'll look for another way. Leave
> this with me for now.
>
> >> I plan to do the rebasing in two phases, mostly to cleanly separate
> >> the bulk stuff from your view. I'm making decent progress on the first
> >> phase. So far a couple things have come up, and I will discuss them
> >> with you in a separate thread so we can explore the way forward as
> >> they come up.
> >
> > Great. I hope the issues can be discussed in terms of adding more/better
> > bindings to repos.
> >
> > Thanks,
> >
> > Steve.
>
[Attachment #3 (text/html)]
<div dir="ltr"><div><div>Hi Steve,<br><br></div>I've tested that this change does \
not appear to break things. Full details, including the testing, in <a \
href="https://git.reviewboard.kde.org/r/129763/">https://git.reviewboard.kde.org/r/129763/</a>. \
Kindly review.<br><br></div>Thanks, Shaheed<br></div><div \
class="gmail_extra"><br><div class="gmail_quote">On 19 January 2017 at 11:25, Shaheed \
Haque <span dir="ltr"><<a href="mailto:srhaque@theiet.org" \
target="_blank">srhaque@theiet.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Steve,<br> <span class=""><br>
On 18 January 2017 at 23:38, Stephen Kelly <<a \
href="mailto:steveire@gmail.com">steveire@gmail.com</a>> wrote:<br> > Shaheed \
Haque wrote:<br> ><br>
>> Hi,<br>
>><br>
>> On 18 January 2017 at 21:44, Stephen Kelly <<a \
href="mailto:steveire@gmail.com">steveire@gmail.com</a>> wrote:<br> >>> \
Shaheed Haque wrote:<br> >>><br>
>>>> HI Steve,<br>
>>>><br>
>>>> I closed two of the reviews based on testing KDE/master. That \
leaves<br> >>>> only <a href="https://git.reviewboard.kde.org/r/129763/" \
rel="noreferrer" target="_blank">https://git.reviewboard.kde.<wbr>org/r/129763/</a>: \
this should be<br> >>>> non-controversial as it removes a functional \
no-op which just gets ion<br> >>>> the way of my stuff, so please take a \
look at it when you can.<br> >>><br>
>>> This doesn't look like a no-op to me. I'm also generally not in \
favor of<br> >>> adding things to ECM which do not directly help the goal of \
getting<br> >>> bindings into frameworks repos.<br>
>><br>
>> If you look at how the CMake constructs ${hdr_filename} and<br>
>> ${hdr_file}, you'll see that they are redundant.<br>
><br>
> Hi Shaheed,<br>
><br>
> It is not uncommon in kde repos (eg kcoreaddons) to specify files in<br>
> subdirectories, yet expect that the filename without subdirectory is what is<br>
> used in the #include. I think that's what you're seeing as \
'redundancy'.<br> > I've extended the ECM test for this case. I \
don't know if your patch affects<br> > it.<br>
<br>
</span>I see (I handle that differently!) so I'll look for another way. Leave<br>
this with me for now.<br>
<div class="HOEnZb"><div class="h5"><br>
>> I plan to do the rebasing in two phases, mostly to cleanly separate<br>
>> the bulk stuff from your view. I'm making decent progress on the \
first<br> >> phase. So far a couple things have come up, and I will discuss \
them<br> >> with you in a separate thread so we can explore the way forward \
as<br> >> they come up.<br>
><br>
> Great. I hope the issues can be discussed in terms of adding more/better<br>
> bindings to repos.<br>
><br>
> Thanks,<br>
><br>
> Steve.<br>
</div></div></blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic