[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bindings
Subject:    Re: [Kde-bindings] qtruby CMakeLists patch
From:       Davor Ocelic <docelic () spinlocksolutions ! com>
Date:       2010-08-19 12:05:06
Message-ID: 20100819140506.11f49517 () sl1 ! spinlock ! hr
[Download RAW message or body]

On Thu, 19 Aug 2010 12:52:30 +0100
Richard Dale <richard.dale@telefonica.net> wrote:

> Are you sure we need to copy FindRUBY.cmake from kdelibs to
> kdebindings. The one in kdebindings is from cmake 2.8 with some
> improvements to work with recent Debian/Kubuntu 1.9.x installations.
> Last time I looked the one in kdelibs was a lot more primitive. 

The cp FindRUBY.cmake instruction has been there for as long as
I remember.

But if that file now ships with kdebindings, I suppose there's
no reason to copy it any more.

> Do we need this:
> 
>  #  cmake                                                         \
>  #    -DCMAKE_INSTALL_PREFIX=/usr/local                           \
>  #    -DRUBY_EXECUTABLE=/usr/local/bin/ruby                       \
> +#    -DRUBY_LIBRARY=/usr/local/lib/libruby.so                    \
>  #    -DRUBY_INCLUDE_PATH=/usr/local/lib/ruby/1.8/i686-linux/     \
>  #    -Wno-dev                                                    \
>  #    -DENABLE_SMOKE=on                                           \
> @@ -59,6 +65,9 @@
> 
> surely the point of cmake is to find all that stuff without it
> needing to be manually set?

Right. In theory, it would detect everything, including ruby executable,
library and include path.

I intended those lines as a quick help for folks who have a custom setup
(e.g. Ruby from source in non-standard location etc.), but I'm fine
either way - feel free to keep or remove the line according to your
judgement.

Thanks,
-doc
_______________________________________________
Kde-bindings mailing list
Kde-bindings@kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings
[prev in list] [next in list] [prev in thread] [next in thread]