[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bindings
Subject:    Re: [Kde-bindings] qtruby CMakeLists patch
From:       Richard Dale <richard.dale () telefonica ! net>
Date:       2010-08-19 11:52:30
Message-ID: 201008191252.31062.richard.dale () telefonica ! net
[Download RAW message or body]

On Thursday, August 19, 2010 12:39:57 pm Davor Ocelic wrote:
> Hey folks,
> 
> Attached is a simple patch bringing CMakeLists.txt.qtruby up to
> date with recent changes etc., so that it works out of the box.
> 
> It is also available on:
> 
>  
> http://techpubs.spinlocksolutions.com/ruby/CMakeLists.txt.qtruby-2010-08-1
> 9.patch
> 
> Cya,
> -doc

Are you sure we need to copy FindRUBY.cmake from kdelibs to kdebindings. The 
one in kdebindings is from cmake 2.8 with some improvements to work with 
recent Debian/Kubuntu 1.9.x installations. Last time I looked the one in 
kdelibs was a lot more primitive. 

Do we need this:

 #  cmake                                                         \
 #    -DCMAKE_INSTALL_PREFIX=/usr/local                           \
 #    -DRUBY_EXECUTABLE=/usr/local/bin/ruby                       \
+#    -DRUBY_LIBRARY=/usr/local/lib/libruby.so                    \
 #    -DRUBY_INCLUDE_PATH=/usr/local/lib/ruby/1.8/i686-linux/     \
 #    -Wno-dev                                                    \
 #    -DENABLE_SMOKE=on                                           \
@@ -59,6 +65,9 @@

surely the point of cmake is to find all that stuff without it needing to be 
manually set?

-- Richard
_______________________________________________
Kde-bindings mailing list
Kde-bindings@kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings
[prev in list] [next in list] [prev in thread] [next in thread]