[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-active
Subject: Re: Review Request 111369: add support for the collection in the active-addons
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-07-03 9:10:25
Message-ID: 20130703091025.14815.31602 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111369/#review35491
-----------------------------------------------------------
i see that the job is currently called BallotJob; apparently this was added by Zack \
when the feature was called "ballots" in the server. since then the API has changed \
to refer to them as collections. for ease of terminology and consistency, all \
occurrences of "Ballot" should be changed to "Collection"
activeclient/src/bodegastore.cpp
<http://git.reviewboard.kde.org/r/111369/#comment26032>
this can be changed in your local configuration, but should not be changed in the \
code.
lib/bodega/ballotlistassetsjobmodel.cpp
<http://git.reviewboard.kde.org/r/111369/#comment26036>
this should have the same set of roles for assets that BodegaModel has, namely:
AssetIdRole
AssetLicenseRole
AssetPartnerIdRole
AssetPartnerNameRole
AssetNameRole
AssetVersionRole
AssetFilenameRole
AssetDescriptionRole
AssetPointsRole
- Aaron J. Seigo
On July 2, 2013, 6:05 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111369/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 6:05 p.m.)
>
>
> Review request for Bodega.
>
>
> Description
> -------
>
> This patch adds support for the collections in the active-addons.
>
>
> Diffs
> -----
>
> activeclient/package/contents/ui/storebrowser/ListBallotsJobColumn.qml PRE-CREATION \
> activeclient/package/contents/ui/storebrowser/ListBallotAssetsJobColumn.qml \
> PRE-CREATION activeclient/package/contents/ui/storebrowser/ItemBrowser.qml 1ba83bf \
> activeclient/package/contents/ui/storebrowser/OverviewColumn.qml 8befff5
> activeclient/src/bodegastore.h a305d11
> activeclient/src/bodegastore.cpp 78ded47
> lib/CMakeLists.txt 381c03f
> lib/bodega/CMakeLists.txt 1ecc498
> lib/bodega/ballotlistassetsjob.cpp 9492f25
> lib/bodega/ballotlistassetsjobmodel.h PRE-CREATION
> lib/bodega/ballotlistassetsjobmodel.cpp PRE-CREATION
> lib/bodega/listballotsjob.cpp 00bf45c
> lib/bodega/listballotsjobmodel.h PRE-CREATION
> lib/bodega/listballotsjobmodel.cpp PRE-CREATION
> lib/bodega/session.cpp 6998da8
>
> Diff: http://git.reviewboard.kde.org/r/111369/diff/
>
>
> Testing
> -------
>
> I have tested the active-addons with the testdata
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/07/02/bodega-collection-native.png
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111369/">http://git.reviewboard.kde.org/r/111369/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i see that the job is \
currently called BallotJob; apparently this was added by Zack when the feature was \
called "ballots" in the server. since then the API has changed to refer to \
them as collections. for ease of terminology and consistency, all occurrences of \
"Ballot" should be changed to "Collection" </pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111369/diff/1/?file=167597#file167597line310" \
style="color: black; font-weight: bold; text-decoration: \
underline;">activeclient/src/bodegastore.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">BodegaStore::BodegaStore()</pre></td> <td colspan="2"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; ">void participantInfoFromQScriptValue(const \
QScriptValue &scriptValue, Bodega::ParticipantInfo &info)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">302</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_session</span><span class="o">-></span><span \
class="n">setBaseUrl</span><span class="p">(</span><span class="n">config</span><span \
class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span \
class="s">"URL"</span><span class="p">,</span> <span \
class="s">"http://<span \
class="hl">addons.makeplaylive.com</span>:3000"</span><span \
class="p">));</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">308</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">m_session</span><span \
class="o">-></span><span class="n">setBaseUrl</span><span class="p">(</span><span \
class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="s">"URL"</span><span class="p">,</span> \
<span class="s">"http://<span class="hl">localhost</span>:3000"</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this can be \
changed in your local configuration, but should not be changed in the code.</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111369/diff/1/?file=167602#file167602line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/bodega/ballotlistassetsjobmodel.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">103</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">roles</span><span class="p">.</span><span class="n">insert</span><span \
class="p">(</span><span class="n">AssetIdRole</span><span class="p">,</span> <span \
class="s">"AssetIdRole"</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">104</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">roles</span><span class="p">.</span><span class="n">insert</span><span \
class="p">(</span><span class="n">AssetNameRole</span><span class="p">,</span> <span \
class="s">"AssetNameRole"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this should \
have the same set of roles for assets that BodegaModel has, namely:
AssetIdRole
AssetLicenseRole
AssetPartnerIdRole
AssetPartnerNameRole
AssetNameRole
AssetVersionRole
AssetFilenameRole
AssetDescriptionRole
AssetPointsRole
</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On July 2nd, 2013, 6:05 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated July 2, 2013, 6:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for the collections in the active-addons.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have tested the active-addons with the testdata</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>activeclient/package/contents/ui/storebrowser/ListBallotsJobColumn.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>activeclient/package/contents/ui/storebrowser/ListBallotAssetsJobColumn.qml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>activeclient/package/contents/ui/storebrowser/ItemBrowser.qml <span \
style="color: grey">(1ba83bf)</span></li>
<li>activeclient/package/contents/ui/storebrowser/OverviewColumn.qml <span \
style="color: grey">(8befff5)</span></li>
<li>activeclient/src/bodegastore.h <span style="color: grey">(a305d11)</span></li>
<li>activeclient/src/bodegastore.cpp <span style="color: grey">(78ded47)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(381c03f)</span></li>
<li>lib/bodega/CMakeLists.txt <span style="color: grey">(1ecc498)</span></li>
<li>lib/bodega/ballotlistassetsjob.cpp <span style="color: \
grey">(9492f25)</span></li>
<li>lib/bodega/ballotlistassetsjobmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/ballotlistassetsjobmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/listballotsjob.cpp <span style="color: grey">(00bf45c)</span></li>
<li>lib/bodega/listballotsjobmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/listballotsjobmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/session.cpp <span style="color: grey">(6998da8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111369/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/02/bodega-collection-native.png">bodega-collection-native.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic