'Review Request 111369: add support for the collection in the active-addons'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Review Request 111369: add support for the collection in the active-addons
From:       "Giorgos Tsiapaliokas" <terietor () gmail ! com>
Date:       2013-07-02 18:05:04
Message-ID: 20130702180504.19715.56960 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111369/
-----------------------------------------------------------

Review request for Bodega.

Description
-------

This patch adds support for the collections in the active-addons.

Diffs
-----

  activeclient/package/contents/ui/storebrowser/ListBallotsJobColumn.qml PRE-CREATION 
  activeclient/package/contents/ui/storebrowser/ListBallotAssetsJobColumn.qml PRE-CREATION 
  activeclient/package/contents/ui/storebrowser/ItemBrowser.qml 1ba83bf 
  activeclient/package/contents/ui/storebrowser/OverviewColumn.qml 8befff5 
  activeclient/src/bodegastore.h a305d11 
  activeclient/src/bodegastore.cpp 78ded47 
  lib/CMakeLists.txt 381c03f 
  lib/bodega/CMakeLists.txt 1ecc498 
  lib/bodega/ballotlistassetsjob.cpp 9492f25 
  lib/bodega/ballotlistassetsjobmodel.h PRE-CREATION 
  lib/bodega/ballotlistassetsjobmodel.cpp PRE-CREATION 
  lib/bodega/listballotsjob.cpp 00bf45c 
  lib/bodega/listballotsjobmodel.h PRE-CREATION 
  lib/bodega/listballotsjobmodel.cpp PRE-CREATION 
  lib/bodega/session.cpp 6998da8 

Diff: http://git.reviewboard.kde.org/r/111369/diff/

Testing
-------

I have tested the active-addons with the testdata

File Attachments
----------------

  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/02/bodega-collection-native.png

Thanks,

Giorgos Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111369/">http://git.reviewboard.kde.org/r/111369/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for the collections in the active-addons.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have tested the active-addons with the testdata</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>activeclient/package/contents/ui/storebrowser/ListBallotsJobColumn.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>activeclient/package/contents/ui/storebrowser/ListBallotAssetsJobColumn.qml \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>activeclient/package/contents/ui/storebrowser/ItemBrowser.qml <span \
style="color: grey">(1ba83bf)</span></li>

 <li>activeclient/package/contents/ui/storebrowser/OverviewColumn.qml <span \
style="color: grey">(8befff5)</span></li>

 <li>activeclient/src/bodegastore.h <span style="color: grey">(a305d11)</span></li>

 <li>activeclient/src/bodegastore.cpp <span style="color: grey">(78ded47)</span></li>

 <li>lib/CMakeLists.txt <span style="color: grey">(381c03f)</span></li>

 <li>lib/bodega/CMakeLists.txt <span style="color: grey">(1ecc498)</span></li>

 <li>lib/bodega/ballotlistassetsjob.cpp <span style="color: \
grey">(9492f25)</span></li>

 <li>lib/bodega/ballotlistassetsjobmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>lib/bodega/ballotlistassetsjobmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>lib/bodega/listballotsjob.cpp <span style="color: grey">(00bf45c)</span></li>

 <li>lib/bodega/listballotsjobmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>lib/bodega/listballotsjobmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>lib/bodega/session.cpp <span style="color: grey">(6998da8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111369/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/02/bodega-collection-native.png">bodega-collection-native.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

[prev in list] [next in list] [prev in thread] [next in thread] 