'Re: Review Request 110796: Bodega-server: Make the test/support/http.js able'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: Review Request 110796: Bodega-server: Make the test/support/http.js able
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2013-06-08 9:43:10
Message-ID: 20130608094310.24967.35709 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110796/#review33933
-----------------------------------------------------------

Ship it!

this doesn't apply against master, but the is good. merge it with current master and push.

- Aaron J. Seigo

On June 3, 2013, 8:35 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110796/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 8:35 a.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> When our url returns html content then the test/support/http.js thinks that there is something wrong 
> because it tries to parse it as a json. With this patch i am fixing that issue.
> 
> 
> Diffs
> -----
> 
>   server/test/support/http.js bb0ad3a 
> 
> Diff: http://git.reviewboard.kde.org/r/110796/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110796/">http://git.reviewboard.kde.org/r/110796/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this doesn&#39;t apply \
against master, but the is good. merge it with current master and push.</pre>  <br />

<p>- Aaron J.</p>

<br />
<p>On June 3rd, 2013, 8:35 a.m. UTC, Antonis Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Bodega.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated June 3, 2013, 8:35 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When our url returns html content then the test/support/http.js thinks \
that there is something wrong  because it tries to parse it as a json. With this \
patch i am fixing that issue.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>server/test/support/http.js <span style="color: grey">(bb0ad3a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110796/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

[prev in list] [next in list] [prev in thread] [next in thread] 