[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jfs-discussion
Subject:    Re: [Jfs-discussion] [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
From:       Chaitanya Kulkarni via Jfs-discussion <jfs-discussion () lists ! sourceforge ! net>
Date:       2022-04-15 5:47:45
Message-ID: 0bf7bda0-0c19-7186-8492-ad894456d98d () nvidia ! com
[Download RAW message or body]

On 4/14/22 21:52, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
> 
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [drbd]
> Acked-by: Jan Höppner <hoeppner@linux.ibm.com> [s390]
> Acked-by: Coly Li <colyli@suse.de> [bcache]
> Acked-by: David Sterba <dsterba@suse.com> [btrfs]
> ---


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck



_______________________________________________
Jfs-discussion mailing list
Jfs-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jfs-discussion

[prev in list] [next in list] [prev in thread] [next in thread]