[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jabber-jadmin
Subject:    Re: [jadmin] authreg_pipe base64 problem was (Re: Debian package for
From:       Jerome Vandenabeele <jerome.vandenabeele_im () gadz ! org>
Date:       2004-11-30 11:29:01
Message-ID: 1101814141.41ac597dc96ea () imp6-q ! free ! fr
[Download RAW message or body]

Hi Stefan,

Selon Stephen Marquard <scm@marquard.net>:
> > BTW: If your using pipe auth in c2s, it's broken I think, but I haven't a
> lot a
> > time to check it this morning.
> If the pipe auth script uses CHECK-PASSWORD or SET-PASSWORD, 2.0s5 now
> passes these base64-encoded (which I think was the original design but
> wasn't done correctly prior to 2.0s5). So the solution is to base64
> decode the password in the script, or you can always just patch -R
That not what I mean, so I explain.

In c2s/authreg_pipe.c, the base64 encoding is done with a 256 char's length:
ap_encode_base64(buf, password, 256);

So when you decode it with perl MIME::Base64, you'll get some funny char after
the original password.
I haven't test, but I think it could be better with something like
ap_encode_base64(buf, password, strlen(password));

I apologise for my previous post, where that wasn't explain
Jerome Vandenabeele
_______________________________________________
jadmin mailing list
jadmin@jabber.org
http://mail.jabber.org/mailman/listinfo/jadmin
FAQ: http://www.jabber.org/wiki/index.php/FAQ-JADMIN
[prev in list] [next in list] [prev in thread] [next in thread]