[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hurd-bug
Subject:    Re: Confusing definitions and declarations of mig_dealloc_reply_port()
From:       Diego Nieto Cid <dnietoc () gmail ! com>
Date:       2015-11-04 13:50:35
Message-ID: CAK5adC5kjpfw_978uy7Mgi0UkHmCLhpmmr4r9q5SjBxjWEGyag () mail ! gmail ! com
[Download RAW message or body]

Hi

2015-11-04 6:30 GMT-03:00 Svante Signell <svante.signell@gmail.com>:
>
> Diego,
> Cc: bug-hurd.

Oh, I mistakenly hit 'Reply'. I hate when that happens :(

> On Tue, 2015-11-03 at 15:55 -0300, Diego Nieto Cid wrote:
>
> > I'd suggest to assert (port == arg || arg == MACH_PORT_NULL) just to
> > be sure users don't expect
> > other port to be deallocated, which would be a bug.
>
> See above.
>

Hmm, I should have written

  assert (__hurd_local_reply_port == arg || arg == MACH_PORT_NULL)

AIUI any other values are bogus given how 'mig_get_reply_port' and
'mig_dealloc_reply_port' are meant to be paired.

May be someone more knowledgeable can shed some ligth to the issue.

> >
> > [*]...probably because of this :)
>
> Why not change mig, is it holy?

No. I just meant whoever wrote that code wasn't willing or didn't have the
time to engage in such a task.

[Attachment #3 (text/html)]

<div dir="ltr">Hi<br><br>2015-11-04 6:30 GMT-03:00 Svante Signell &lt;<a \
href="mailto:svante.signell@gmail.com">svante.signell@gmail.com</a>&gt;:<br>&gt;<br>&gt; \
Diego,<br>&gt; Cc: bug-hurd.<br><br>Oh, I mistakenly hit &#39;Reply&#39;. I hate when \
that happens :(<br><br>&gt; On Tue, 2015-11-03 at 15:55 -0300, Diego Nieto Cid \
wrote:<br>&gt;<br>&gt; &gt; I&#39;d suggest to assert (port == arg || arg == \
MACH_PORT_NULL) just to<br>&gt; &gt; be sure users don&#39;t expect<br>&gt; &gt; \
other port to be deallocated, which would be a bug.<br>&gt;<br>&gt; See \
above.<br>&gt;<br><br>Hmm, I should have written<br><br>   assert \
(__hurd_local_reply_port == arg || arg == MACH_PORT_NULL)<br><br>AIUI any other \
values are bogus given how &#39;mig_get_reply_port&#39; and \
&#39;mig_dealloc_reply_port&#39; are meant to be paired.<br><br>May be someone more \
knowledgeable can shed some ligth to the issue.<br><br>&gt; &gt;<br>&gt; &gt; \
[*]...probably because of this :)<br>&gt;<br>&gt; Why not change mig, is it \
holy?<br><br>No. I just meant whoever wrote that code wasn&#39;t willing or \
didn&#39;t have the time to engage in such a task.</div>



[prev in list] [next in list] [prev in thread] [next in thread]