[prev in list] [next in list] [prev in thread] [next in thread] 

List:       htmlunit-develop
Subject:    [HtmlUnit] SVN: [11942] trunk/htmlunit/src
From:       asashour () users ! sourceforge ! net
Date:       2016-02-29 12:58:50
Message-ID: E1aaNPZ-00083Z-Bi () sfs-ml-3 ! v29 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Revision: 11942
          http://sourceforge.net/p/htmlunit/code/11942
Author:   asashour
Date:     2016-02-29 12:58:50 +0000 (Mon, 29 Feb 2016)
Log Message:
-----------
Fixing build

Modified Paths:
--------------
    trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java
  trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableRowElement.java
  trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableSectionElement.java
  trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/dom/DOMParserTest.java
  trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/libraries/JQuery1x11x3Test.java


Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java
 ===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java	2016-02-29 \
                11:14:37 UTC (rev 11941)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java	2016-02-29 \
12:58:50 UTC (rev 11942) @@ -965,6 +965,10 @@
     @BrowserFeature(@WebBrowser(IE))
     JS_INNER_TEXT_CR_NL,
 
+    /** Indicates that innerText is readonly for tables. */
+    @BrowserFeature(@WebBrowser(CHROME))
+    JS_INNER_TEXT_READONLY_FOR_TABLE,
+
     /** Setting the type property of an input converts the type to lowercase. */
     @BrowserFeature(@WebBrowser(IE))
     JS_INPUT_SET_TYPE_LOWERCASE,
@@ -1218,7 +1222,7 @@
     @BrowserFeature({ @WebBrowser(CHROME), @WebBrowser(FF) })
     JS_TABLE_COLUMN_WIDTH_NULL_STRING,
 
-    /** Calling deleteCell without an index throws an exeption. */
+    /** Calling deleteCell without an index throws an exception. */
     @BrowserFeature({ @WebBrowser(CHROME), @WebBrowser(FF) })
     JS_TABLE_ROW_DELETE_CELL_REQUIRES_INDEX,
 

Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableRowElement.java
 ===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableRowElement.java	2016-02-29 \
                11:14:37 UTC (rev 11941)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableRowElement.java	2016-02-29 \
12:58:50 UTC (rev 11942) @@ -14,6 +14,7 @@
  */
 package com.gargoylesoftware.htmlunit.javascript.host.html;
 
+import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.JS_INNER_TEXT_READONLY_FOR_TABLE;
  import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.JS_TABLE_ROW_DELETE_CELL_REQUIRES_INDEX;
  import static com.gargoylesoftware.htmlunit.javascript.configuration.BrowserName.CHROME;
  import static com.gargoylesoftware.htmlunit.javascript.configuration.BrowserName.EDGE;
 @@ -208,6 +209,19 @@
     }
 
     /**
+     * Overwritten to throw an exception because this is readonly.
+     * @param value the new value for the contents of this node
+     */
+    @JsxSetter({ @WebBrowser(IE), @WebBrowser(CHROME) })
+    @Override
+    public void setInnerText(final String value) {
+        if (getBrowserVersion().hasFeature(JS_INNER_TEXT_READONLY_FOR_TABLE)) {
+            throw Context.reportRuntimeError("innerText is read-only for tag 'tr'");
+        }
+        super.setInnerText(value);
+    }
+
+    /**
      * Gets the {@code borderColor} attribute.
      * @return the attribute
      */

Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableSectionElement.java
 ===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableSectionElement.java	2016-02-29 \
                11:14:37 UTC (rev 11941)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableSectionElement.java	2016-02-29 \
12:58:50 UTC (rev 11942) @@ -14,6 +14,7 @@
  */
 package com.gargoylesoftware.htmlunit.javascript.host.html;
 
+import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.JS_INNER_TEXT_READONLY_FOR_TABLE;
  import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.JS_TABLE_VALIGN_SUPPORTS_IE_VALUES;
  import static com.gargoylesoftware.htmlunit.javascript.configuration.BrowserName.CHROME;
  import static com.gargoylesoftware.htmlunit.javascript.configuration.BrowserName.EDGE;
 @@ -160,4 +161,17 @@
                             + getDomNodeOrDie().getNodeName() + "'");
     }
 
+    /**
+     * Overwritten to throw an exception because this is readonly.
+     * @param value the new value for the contents of this node
+     */
+    @JsxSetter({ @WebBrowser(IE), @WebBrowser(CHROME) })
+    @Override
+    public void setInnerText(final String value) {
+        if (getBrowserVersion().hasFeature(JS_INNER_TEXT_READONLY_FOR_TABLE)) {
+            throw Context.reportRuntimeError("innerText is read-only for tag '"
+                    + getDomNodeOrDie().getNodeName() + "'");
+        }
+        super.setInnerText(value);
+    }
 }

Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/dom/DOMParserTest.java
 ===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/dom/DOMParserTest.java	2016-02-29 \
                11:14:37 UTC (rev 11941)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/dom/DOMParserTest.java	2016-02-29 \
12:58:50 UTC (rev 11942) @@ -16,7 +16,6 @@
 
 import static com.gargoylesoftware.htmlunit.BrowserRunner.Browser.CHROME;
 import static com.gargoylesoftware.htmlunit.BrowserRunner.Browser.FF;
-import static com.gargoylesoftware.htmlunit.BrowserRunner.Browser.IE;
 
 import org.junit.Test;
 import org.junit.runner.RunWith;

Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/libraries/JQuery1x11x3Test.java
 ===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/libraries/JQuery1x11x3Test.java	2016-02-29 \
                11:14:37 UTC (rev 11941)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/libraries/JQuery1x11x3Test.java	2016-02-29 \
12:58:50 UTC (rev 11942) @@ -3712,7 +3712,6 @@
      */
     @Test
     @Alerts("0, 78, 78")
-    @NotYetImplemented(CHROME)
     public void manipulation__append_String_Element_Array_Element__jQuery_() throws \
                Exception {
         runTest("manipulation: append(String|Element|Array<Element>|jQuery)");
     }
@@ -3723,7 +3722,6 @@
      */
     @Test
     @Alerts("0, 78, 78")
-    @NotYetImplemented(CHROME)
     public void manipulation__append_Function_() throws Exception {
         runTest("manipulation: append(Function)");
     }


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
HtmlUnit-develop mailing list
HtmlUnit-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop


[prev in list] [next in list] [prev in thread] [next in thread]