[prev in list] [next in list] [prev in thread] [next in thread] 

List:       htmlunit-develop
Subject:    [HtmlUnit] SVN: [11941] trunk/htmlunit/src
From:       asashour () users ! sourceforge ! net
Date:       2016-02-29 11:14:38
Message-ID: E1aaLmj-0006a3-Kz () sfs-ml-1 ! v29 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Revision: 11941
          http://sourceforge.net/p/htmlunit/code/11941
Author:   asashour
Date:     2016-02-29 11:14:37 +0000 (Mon, 29 Feb 2016)
Log Message:
-----------
XMLHttpRequest: Chrome also fires state loading twice in async mode

Modified Paths:
--------------
    trunk/htmlunit/src/changes/changes.xml
    trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java
  trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/xml/XMLHttpRequest.java
  trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/xml/XMLHttpRequest3Test.java


Modified: trunk/htmlunit/src/changes/changes.xml
===================================================================
--- trunk/htmlunit/src/changes/changes.xml	2016-02-29 11:06:32 UTC (rev 11940)
+++ trunk/htmlunit/src/changes/changes.xml	2016-02-29 11:14:37 UTC (rev 11941)
@@ -9,6 +9,9 @@
     <body>
         <release version="2.21" date="???" description="Bugfixes">
             <action type="fix" dev="asashour">
+                XMLHttpRequest: Chrome also fires state loading twice in async mode.
+            </action>
+            <action type="fix" dev="asashour">
                 JavaScript: HTMLTableElement.innerText should not be read-only \
(Chrome).  </action>
             <action type="remove" dev="asashour">

Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java
 ===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java	2016-02-29 \
                11:06:32 UTC (rev 11940)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java	2016-02-29 \
11:14:37 UTC (rev 11941) @@ -1497,7 +1497,7 @@
     WINDOW_EXECUTE_EVENTS,
 
     /** XMLHttpRequest triggers the opened event at the beginning of the send method \
                again. */
-    @BrowserFeature(@WebBrowser(IE))
+    @BrowserFeature({ @WebBrowser(CHROME), @WebBrowser(IE) })
     XHR_FIRE_STATE_OPENED_AGAIN_IN_ASYNC_MODE,
 
     /**

Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/xml/XMLHttpRequest.java
 ===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/xml/XMLHttpRequest.java	2016-02-29 \
                11:06:32 UTC (rev 11940)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/xml/XMLHttpRequest.java	2016-02-29 \
11:14:37 UTC (rev 11941) @@ -616,7 +616,7 @@
         }
         else {
             if (getBrowserVersion().hasFeature(XHR_FIRE_STATE_OPENED_AGAIN_IN_ASYNC_MODE)) \
                {
-                // quite strange but IE and FF seem both to fire state loading twice
+                // quite strange but IE and Chrome seem both to fire state loading \
twice  // in async mode (at least with HTML of the unit tests)
                 setState(OPENED, Context.getCurrentContext());
             }

Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/xml/XMLHttpRequest3Test.java
 ===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/xml/XMLHttpRequest3Test.java	2016-02-29 \
                11:06:32 UTC (rev 11940)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/xml/XMLHttpRequest3Test.java	2016-02-29 \
11:14:37 UTC (rev 11941) @@ -14,8 +14,6 @@
  */
 package com.gargoylesoftware.htmlunit.javascript.host.xml;
 
-import static com.gargoylesoftware.htmlunit.BrowserRunner.Browser.CHROME;
-
 import java.io.IOException;
 import java.io.Writer;
 import java.net.URL;
@@ -78,7 +76,6 @@
     @Test
     @Alerts(DEFAULT = { "0", "1", "1", "2", "3", "4" },
                 FF = { "0", "1", "2", "3", "4" })
-    @NotYetImplemented(CHROME)
     public void asyncUse() throws Exception {
         final String html =
               "<html>\n"
@@ -130,7 +127,6 @@
     @Test
     @Alerts(DEFAULT = { "0", "1", "1", "2", "4", MSG_NO_CONTENT, \
                MSG_PROCESSING_ERROR },
             FF = { "0", "1", "2", "4", MSG_NO_CONTENT, MSG_PROCESSING_ERROR })
-    @NotYetImplemented(CHROME)
     public void testAsyncUseWithNetworkConnectionFailure() throws Exception {
         final String html =
               "<html>\n"


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
HtmlUnit-develop mailing list
HtmlUnit-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic